fix(efs): cannot use encryption key imported from another account #11524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the `keyId` property supports using the ARN or the key ID. this change uses the ARN as it's more robust and allows usage of a key which is cross-account. It currently fails as the ID is looked up within the same account and not found. Closes #7641
|
|
NetaNir
approved these changes
Nov 17, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mergify bot
pushed a commit
that referenced
this pull request
Nov 27, 2020
The change made in #11524 which switched from using the `keyId` to `keyArn` is a BREAKING change as an update requires replacement: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-efs-filesystem.html#cfn-efs-filesystem-kmskeyid The `efs` module is experimental and this was a capability that needed to be fixed ahead of moving to developer preview. It was missed that an update to the keyId replaces the filesystem. Amending the CHANGELOG to indicate that the filesystem will be replaced. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
keyIdproperty supports using the ARN or the key ID.this change uses the ARN as it's more robust and allows usage of
a key which is cross-account.
It currently fails as the ID is looked up within the same account
and not found.
Closes #7641
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license