fix(core): reusing StackSynthesizer leads to unsynthesized Stacks #11635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the same StackSynthesizer object is used for multiple stacks, only the last one is properly synthesized to the cloud assembly. Ideally, we would have made it so that there is a difference between the specifying `StackSynthesizer` object and a "bound" version of the `StackSynthesizer` (bound to a `Stack`). Unfortunately, we cannot introduce that change without heavy contortions in order not to break backwards compatibility, so the simple thing to do right now is to make it blindingly obvious that "you cannot do that". Fixes #11528.
|
|
nija-at
approved these changes
Nov 24, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the same StackSynthesizer object is used for multiple stacks,
only the last one is properly synthesized to the cloud assembly.
Ideally, we would have made it so that there is a difference between
the specifying
StackSynthesizerobject and a "bound" version ofthe
StackSynthesizer(bound to aStack).Unfortunately, we cannot introduce that change without heavy
contortions in order not to break backwards compatibility, so the
simple thing to do right now is to make it blindingly obvious that
"you cannot do that".
Fixes #11528.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license