Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bootstrap message print out exact command & environment #1188

Closed
rix0rrr opened this issue Nov 15, 2018 · 0 comments · Fixed by #1191
Closed

Make bootstrap message print out exact command & environment #1188

rix0rrr opened this issue Nov 15, 2018 · 0 comments · Fixed by #1191
Labels
package/tools Related to AWS CDK Tools or CLI

Comments

@rix0rrr
Copy link
Contributor

rix0rrr commented Nov 15, 2018

Right now it just says "cdk bootstrap" but that by itself is not enough.

@rix0rrr rix0rrr added the package/tools Related to AWS CDK Tools or CLI label Nov 15, 2018
rix0rrr added a commit that referenced this issue Nov 16, 2018
Improve the error message when needing to bootstrap while using assets.
Also make it not necessary to have '--app' in there when bootstrapping
if an environment name is given.

This makes the toolkit easier to use in integration tests, where the
cdk.json is generated and it's not clear what the argument to --app
should be (nor should it be necessary if the environment identifier has
enough information in it to reconstruct the Environment object).

This also refactors the code somewhat so related code (for running the
CX App and parsing its output) is together.

Fixes #1188.
rix0rrr added a commit that referenced this issue Nov 16, 2018
Improve the error message when needing to bootstrap while using assets.
Also make it not necessary to have '--app' in there when bootstrapping
if an environment name is given.

This makes the toolkit easier to use in integration tests, where the
cdk.json is generated and it's not clear what the argument to --app
should be (nor should it be necessary if the environment identifier has
enough information in it to reconstruct the Environment object).

This also refactors the code somewhat so related code (for running the
CX App and parsing its output) is together.

Fixes #1188.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant