feat(events): archive events #12060
feat(events): archive events #12060
Conversation
|
|
|
Hi @shivlaks , any chance I could get a review for this ? Thanks ! |
…orted by cloudformation latest version
| */ | ||
| public abstract readonly eventSourceName?: string; | ||
|
|
||
| public archive(props: BaseArchiveProps): Archive { |
There was a problem hiding this comment.
Please still add the id parameter.
| public archive(props: BaseArchiveProps): Archive { | ||
| return new Archive(this, 'Archive', { | ||
| sourceEventBus: this, | ||
| description: props.description || Lazy.string({ produce: () => `Event Archive for ${this.eventBusName} Event Bus` }), |
There was a problem hiding this comment.
This doesn't need to be a Lazy.
| eventBusName: 'MyCustomEventBus' | ||
| }); | ||
|
|
||
| bus.archive( |
There was a problem hiding this comment.
Example needs braces { ... }.
| sourceArn: props.sourceEventBus.eventBusArn, | ||
| description: props.description, | ||
| eventPattern: props.eventPattern, | ||
| retentionDays: props.retention?.toDays() || 0, |
There was a problem hiding this comment.
You probably want to pass { integral: true } to toDays() otherwise it may lead to values like 0.5.
mergify
bot
dismissed
rix0rrr’s stale review
Pull request has been modified.
rix0rrr
changed the title
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Add the possibility to archive events from an Event Bus. It's also possible to archive specific events by passing an event patterns. See the following blogpost for more information about event archiving and replay.
Archiving should be possible from an imported EventBus.
closes #11531
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license