feat(ec2): Add VPC endpoint for RDS #12497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
@aws-cdk/aws-ec2
NetaNir
previously approved these changes
Jan 19, 2021
NetaNir
added
pr-linter/exempt-readme
NetaNir
previously approved these changes
Jan 21, 2021
rix0rrr
previously approved these changes
Feb 9, 2021
rix0rrr
previously approved these changes
Feb 9, 2021
rix0rrr
force-pushed
the
feature/rds-vpc-endpoint
branch
from
45c12b6
to
697fb77
Compare
rix0rrr
previously approved these changes
Feb 9, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mergify
bot
dismissed
rix0rrr’s stale review
Pull request has been modified.
rix0rrr
approved these changes
Feb 10, 2021
|
What is the status here? This has become incredibly painful for what was a simple 1-line change. :( |
|
It is not even clear to me why this has become so painful. |
|
Oh I remember. It's because static initialization of an additional token messed up something in the APIGatewayV2 module. Thanks for exposing that bug! I think I can fix your PR by rebasing some commits. |
rix0rrr
force-pushed
the
feature/rds-vpc-endpoint
branch
from
c9bc853
to
64b7f7d
Compare
|
There we go. |
rix0rrr
previously approved these changes
Feb 25, 2021
mergify
bot
dismissed
rix0rrr’s stale review
Pull request has been modified.
|
Thanks @rix0rrr! I'll give this an update with master and hopefully the great merge train will proceed. :) |
rix0rrr
approved these changes
Feb 26, 2021
This was referenced Mar 6, 2021
Merged
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds VPC endpoint support for RDS. Fixes #12402
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license