Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lambda): code signing config #12656

Merged
merged 51 commits into from
Feb 25, 2021
Merged

feat(lambda): code signing config #12656

merged 51 commits into from
Feb 25, 2021

Conversation

hedrall
Copy link
Contributor

@hedrall hedrall commented Jan 22, 2021 •
edited by nija-at
Loading

closes #12216

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jan 22, 2021 •
edited
Loading

@hedrall hedrall changed the title feat(lambda-code-signing): create draft code feat(aws-lambda): create draft code Jan 22, 2021
@github-actions github-actions bot added the @aws-cdk/aws-lambda Related to AWS Lambda label Jan 22, 2021
@hedrall hedrall changed the title feat(aws-lambda): create draft code feat(aws-lambda): add code signing feature of lambda function Jan 22, 2021
@hedrall hedrall changed the title feat(aws-lambda): add code signing feature of lambda function feat(aws-lambda): add code signing feature of lambda function (#12216) Jan 22, 2021
@nija-at nija-at changed the title feat(aws-lambda): add code signing feature of lambda function (#12216) feat(lambda): code signing config (#12216) Jan 25, 2021
nija-at
nija-at previously requested changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this PR and taking interest in contributing to the CDK 😊

Before we get into the details, I one high level comment below.

packages/@aws-cdk/aws-lambda/lib/code-signing-config.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-lambda/lib/code-signing-config.ts Outdated Show resolved Hide resolved
@mergify mergify bot dismissed nija-at’s stale review January 27, 2021 22:40

Pull request has been modified.

@hedrall
Copy link
Contributor Author

hedrall commented Jan 27, 2021

@nija-at
Thank you for your kind advaice. ( and I checked design guidelines. )

I create construct of SigningProfile in aws-signer/signing-profile.ts and modify aws-lambda/codeSigningConfig.
( Do you prefer to split SigningProfile construct to other PR? )

nija-at
nija-at previously requested changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at why this build is failing and fix any issues there. The automated comment above has the link to the logs.

The current error can be fixed by running yarn pkglint locally on the package.

packages/@aws-cdk/aws-signer/lib/signer-profile.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-signer/lib/signer-profile.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-signer/lib/signer-profile.ts Outdated Show resolved Hide resolved
modify @Attribute => @Attribute
b1b3f40 
delete class SigningProfileBase
execute `yarn pkglint` and fix 'maturity' in package.json
@mergify mergify bot dismissed nija-at’s stale review February 2, 2021 23:05

Pull request has been modified.

@hedrall
Copy link
Contributor Author

hedrall commented Feb 3, 2021

@nija-at
I have fixed and suppressed some CI errors.
I would appreciate it if you could check it out.

nija-at
nija-at previously requested changes Feb 4, 2021
View reviewed changes
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build is failing again. Please continue to work on this until you're able to get the build to pass.
You should be able to reproduce this error by setting up the partial build workflow and the running yarn build.

See my comments below.

packages/@aws-cdk/aws-lambda/lib/code-signing-config.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-lambda/lib/code-signing-config.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-lambda/lib/code-signing-config.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-signer/lib/signer-profile.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-signer/test/signer.test.ts Outdated Show resolved Hide resolved
make signingProfiles to list
f10b46f 
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
@mergify mergify bot dismissed nija-at’s stale review February 4, 2021 21:29

Pull request has been modified.

@hedrall
Copy link
Contributor Author

hedrall commented Feb 6, 2021

@nija-at
Thank you for pointing this out again.
I fixed the codes and hope you will check again!

This was referenced Mar 8, 2021
Closed
Merged
Merged
Merged
Closed
Closed
Closed
Closed
Merged
Closed
Merged
Merged
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Closed
@dontirun dontirun mentioned this pull request Mar 16, 2021
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nija-at nija-at nija-at approved these changes

Assignees

@nija-at nija-at

Labels
@aws-cdk/aws-lambda Related to AWS Lambda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(lambda): Add ability to sign code using a code signing profile
4 participants
@hedrall @aws-cdk-automation @nija-at @MrArnoldPalmer