Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ec2): fix typo's in WindowsImage constants #13446

Merged
merged 3 commits into from
Mar 9, 2021

Conversation

robertd
Copy link
Contributor

@robertd robertd commented Mar 6, 2021

Admittedly, they are typo fixes, but they're breaking API so they had to be deprecated and replaced... hence the "fix(ec2)" prefix.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Mar 6, 2021

@github-actions github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Mar 6, 2021
@rix0rrr rix0rrr changed the title fix(ec2): fix Windows version to use for the WindowsImage fix(ec2): fix typo's in WindowsImage constants Mar 8, 2021
rix0rrr
rix0rrr previously approved these changes Mar 8, 2021
@rix0rrr rix0rrr added the pr-linter/exempt-test The PR linter will not require test changes label Mar 8, 2021
@mergify mergify bot dismissed rix0rrr’s stale review March 9, 2021 10:18

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Mar 9, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: fd0e082
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 9, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

This was referenced Mar 14, 2021
@robertd robertd deleted the robertd/ec2-windows branch January 20, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants