fix(cloudwatch): cannot create Alarms from labeled metrics that start with a digit #13560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
@aws-cdk/aws-cloudwatch
BLasan
force-pushed
the
issue-13434
branch
2 times, most recently
from
a8e930e
to
24e012b
Compare
rix0rrr
reviewed
Mar 12, 2021
| @@ -283,7 +283,7 @@ export class Alarm extends AlarmBase { | |||
| stat: stat.statistic, | |||
| unit: stat.unitFilter, | |||
| }, | |||
| id: stat.metricName, | |||
| id: id, | |||
There was a problem hiding this comment.
Suggested change
| id: id, | |
| id, |
Otherwise the linter will yell at you
There was a problem hiding this comment.
My bad. Thanks for pointing me out :)
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
rix0rrr
changed the title
rix0rrr
approved these changes
Mar 12, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This was referenced Mar 17, 2021
Closed
This was referenced Mar 17, 2021
Closed
Closed
mergify bot
pushed a commit
to nikovirtala/cdk-preview-environments
that referenced
this pull request
Mar 17, 2021
…3.0 to 1.94.1 (#173) [//]: # (dependabot-start)⚠️ **Dependabot is rebasing this PR**⚠️ If you make any changes to it yourself then they will take precedence over the rebase. --- [//]: # (dependabot-end) Bumps [@aws-cdk-containers/ecs-service-extensions](https://github.com/aws/aws-cdk/tree/HEAD/packages/@aws-cdk-containers/ecs-service-extensions) from 1.93.0 to 1.94.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-cdk/releases"><code>@aws-cdk-containers/ecs-service-extensions's releases</code></a>.</em></p> <blockquote> <h2>v1.94.1</h2> <h3>Bug Fixes</h3> <ul> <li><strong>s3:</strong> Notifications fail to deploy due to incompatible node runtime (<a href="https://github.com/aws/aws-cdk/issues/13624">#13624</a>) (<a href="https://github.com/aws/aws-cdk/commit/26bc3d4951a96a4bdf3e3e10464a4e3b80ed563f">26bc3d4</a>)</li> </ul> <h2>v1.94.0</h2> <h3>⚠ BREAKING CHANGES TO EXPERIMENTAL FEATURES</h3> <ul> <li><strong>appmesh:</strong> Backend, backend default and Virtual Service client policies structures are being altered</li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualGateway</code>. The property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code></li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualNode</code>, (the property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code>), and the <code>Backend</code> class to define a backend</li> <li><strong>appmesh</strong>: you can no longer attach a client policy to a <code>VirtualService</code></li> </ul> <h3>Features</h3> <ul> <li><strong>appmesh:</strong> add missing route match features (<a href="https://github.com/aws/aws-cdk/issues/13350">#13350</a>) (<a href="https://github.com/aws/aws-cdk/commit/b71efd9d12843ab4b495d53e565cec97d60748f3">b71efd9</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11645">#11645</a></li> <li><strong>aws-elasticloadbalancingv2:</strong> add protocol version for ALB TargetGroups (<a href="https://github.com/aws/aws-cdk/issues/13570">#13570</a>) (<a href="https://github.com/aws/aws-cdk/commit/165a3d877b7ab23f29e42e1e74ee7c5cb35b7f24">165a3d8</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12869">#12869</a></li> <li><strong>ecs-patterns:</strong> Add ECS deployment circuit breaker support to higher-level constructs (<a href="https://github.com/aws/aws-cdk/issues/12719">#12719</a>) (<a href="https://github.com/aws/aws-cdk/commit/e80a98aa8839e9b9b89701158d82b991e9ebaa65">e80a98a</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12534">#12534</a> <a href="https://github.com/aws/aws-cdk/issues/12360">#12360</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>appmesh:</strong> Move Client Policy from Virtual Service to backend structure (<a href="https://github.com/aws/aws-cdk/issues/12943">#12943</a>) (<a href="https://github.com/aws/aws-cdk/commit/d3f428435976c55ca950279cfc841665fd504370">d3f4284</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11996">#11996</a></li> <li><strong>autoscaling:</strong> AutoScaling on percentile metrics doesn't work (<a href="https://github.com/aws/aws-cdk/issues/13366">#13366</a>) (<a href="https://github.com/aws/aws-cdk/commit/46114bb1f4702019a8873b9162d0a9f10763bc61">46114bb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13144">#13144</a></li> <li><strong>cloudwatch:</strong> cannot create Alarms from labeled metrics that start with a digit (<a href="https://github.com/aws/aws-cdk/issues/13560">#13560</a>) (<a href="https://github.com/aws/aws-cdk/commit/278029f25b41d956091835364e5a8de91429712c">278029f</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13434">#13434</a></li> <li>use NodeJS 14 for all packaged custom resources (<a href="https://github.com/aws/aws-cdk/issues/13488">#13488</a>) (<a href="https://github.com/aws/aws-cdk/commit/20a2820ee4d022663fcd0928fbc0f61153ae953f">20a2820</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13534">#13534</a> <a href="https://github.com/aws/aws-cdk/issues/13484">#13484</a></li> <li><strong>ec2:</strong> Security Groups support all protocols (<a href="https://github.com/aws/aws-cdk/issues/13593">#13593</a>) (<a href="https://github.com/aws/aws-cdk/commit/8c6b3ebea464e27f68ffcab32857d8baec29c413">8c6b3eb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13403">#13403</a></li> <li><strong>lambda:</strong> fromDockerBuild output is located under /asset (<a href="https://github.com/aws/aws-cdk/issues/13539">#13539</a>) (<a href="https://github.com/aws/aws-cdk/commit/77449f61e7075fef1240fc52becb8ea60b9ea9ad">77449f6</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13439">#13439</a></li> <li><strong>region-info:</strong> ap-northeast-3 data not correctly registered (<a href="https://github.com/aws/aws-cdk/issues/13564">#13564</a>) (<a href="https://github.com/aws/aws-cdk/commit/64da84be5c60bb8132551bcc27a7ca9c7effe95d">64da84b</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13561">#13561</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-cdk/blob/master/CHANGELOG.md"><code>@aws-cdk-containers/ecs-service-extensions's changelog</code></a>.</em></p> <blockquote> <h2><a href="https://github.com/aws/aws-cdk/compare/v1.94.0...v1.94.1">1.94.1</a> (2021-03-16)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>s3:</strong> Notifications fail to deploy due to incompatible node runtime (<a href="https://github.com/aws/aws-cdk/issues/13624">#13624</a>) (<a href="https://github.com/aws/aws-cdk/commit/26bc3d4951a96a4bdf3e3e10464a4e3b80ed563f">26bc3d4</a>)</li> </ul> <h2><a href="https://github.com/aws/aws-cdk/compare/v1.93.0...v1.94.0">1.94.0</a> (2021-03-16)</h2> <h3>⚠ BREAKING CHANGES TO EXPERIMENTAL FEATURES</h3> <ul> <li><strong>appmesh:</strong> Backend, backend default and Virtual Service client policies structures are being altered</li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualGateway</code>. The property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code></li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualNode</code>, (the property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code>), and the <code>Backend</code> class to define a backend</li> <li><strong>appmesh</strong>: you can no longer attach a client policy to a <code>VirtualService</code></li> </ul> <h3>Features</h3> <ul> <li><strong>appmesh:</strong> add missing route match features (<a href="https://github.com/aws/aws-cdk/issues/13350">#13350</a>) (<a href="https://github.com/aws/aws-cdk/commit/b71efd9d12843ab4b495d53e565cec97d60748f3">b71efd9</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11645">#11645</a></li> <li><strong>aws-elasticloadbalancingv2:</strong> add protocol version for ALB TargetGroups (<a href="https://github.com/aws/aws-cdk/issues/13570">#13570</a>) (<a href="https://github.com/aws/aws-cdk/commit/165a3d877b7ab23f29e42e1e74ee7c5cb35b7f24">165a3d8</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12869">#12869</a></li> <li><strong>ecs-patterns:</strong> Add ECS deployment circuit breaker support to higher-level constructs (<a href="https://github.com/aws/aws-cdk/issues/12719">#12719</a>) (<a href="https://github.com/aws/aws-cdk/commit/e80a98aa8839e9b9b89701158d82b991e9ebaa65">e80a98a</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12534">#12534</a> <a href="https://github.com/aws/aws-cdk/issues/12360">#12360</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>appmesh:</strong> Move Client Policy from Virtual Service to backend structure (<a href="https://github.com/aws/aws-cdk/issues/12943">#12943</a>) (<a href="https://github.com/aws/aws-cdk/commit/d3f428435976c55ca950279cfc841665fd504370">d3f4284</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11996">#11996</a></li> <li><strong>autoscaling:</strong> AutoScaling on percentile metrics doesn't work (<a href="https://github.com/aws/aws-cdk/issues/13366">#13366</a>) (<a href="https://github.com/aws/aws-cdk/commit/46114bb1f4702019a8873b9162d0a9f10763bc61">46114bb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13144">#13144</a></li> <li><strong>cloudwatch:</strong> cannot create Alarms from labeled metrics that start with a digit (<a href="https://github.com/aws/aws-cdk/issues/13560">#13560</a>) (<a href="https://github.com/aws/aws-cdk/commit/278029f25b41d956091835364e5a8de91429712c">278029f</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13434">#13434</a></li> <li>use NodeJS 14 for all packaged custom resources (<a href="https://github.com/aws/aws-cdk/issues/13488">#13488</a>) (<a href="https://github.com/aws/aws-cdk/commit/20a2820ee4d022663fcd0928fbc0f61153ae953f">20a2820</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13534">#13534</a> <a href="https://github.com/aws/aws-cdk/issues/13484">#13484</a></li> <li><strong>ec2:</strong> Security Groups support all protocols (<a href="https://github.com/aws/aws-cdk/issues/13593">#13593</a>) (<a href="https://github.com/aws/aws-cdk/commit/8c6b3ebea464e27f68ffcab32857d8baec29c413">8c6b3eb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13403">#13403</a></li> <li><strong>lambda:</strong> fromDockerBuild output is located under /asset (<a href="https://github.com/aws/aws-cdk/issues/13539">#13539</a>) (<a href="https://github.com/aws/aws-cdk/commit/77449f61e7075fef1240fc52becb8ea60b9ea9ad">77449f6</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13439">#13439</a></li> <li><strong>region-info:</strong> ap-northeast-3 data not correctly registered (<a href="https://github.com/aws/aws-cdk/issues/13564">#13564</a>) (<a href="https://github.com/aws/aws-cdk/commit/64da84be5c60bb8132551bcc27a7ca9c7effe95d">64da84b</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13561">#13561</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/aws/aws-cdk/commit/20a2820ee4d022663fcd0928fbc0f61153ae953f"><code>20a2820</code></a> fix: use NodeJS 14 for all packaged custom resources (<a href="https://github.com/aws/aws-cdk/tree/HEAD/packages/@aws-cdk-containers/ecs-service-extensions/issues/13488">#13488</a>)</li> <li><a href="https://github.com/aws/aws-cdk/commit/d3f428435976c55ca950279cfc841665fd504370"><code>d3f4284</code></a> fix(appmesh): Move Client Policy from Virtual Service to backend structure (#...</li> <li>See full diff in <a href="https://github.com/aws/aws-cdk/commits/v1.94.1/packages/@aws-cdk-containers/ecs-service-extensions">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually </details>
This was referenced Mar 17, 2021
Closed
mergify bot
added a commit
to trexcoe/smile-jenkins
that referenced
this pull request
Mar 17, 2021
[//]: # (dependabot-start)⚠️ **Dependabot is rebasing this PR**⚠️ If you make any changes to it yourself then they will take precedence over the rebase. --- [//]: # (dependabot-end) Bumps [@aws-cdk/core](https://github.com/aws/aws-cdk/tree/HEAD/packages/@aws-cdk/core) from 1.93.0 to 1.94.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-cdk/releases"><code>@aws-cdk/core's releases</code></a>.</em></p> <blockquote> <h2>v1.94.1</h2> <h3>Bug Fixes</h3> <ul> <li><strong>s3:</strong> Notifications fail to deploy due to incompatible node runtime (<a href="https://github.com/aws/aws-cdk/issues/13624">#13624</a>) (<a href="https://github.com/aws/aws-cdk/commit/26bc3d4951a96a4bdf3e3e10464a4e3b80ed563f">26bc3d4</a>)</li> </ul> <h2>v1.94.0</h2> <h3>⚠ BREAKING CHANGES TO EXPERIMENTAL FEATURES</h3> <ul> <li><strong>appmesh:</strong> Backend, backend default and Virtual Service client policies structures are being altered</li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualGateway</code>. The property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code></li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualNode</code>, (the property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code>), and the <code>Backend</code> class to define a backend</li> <li><strong>appmesh</strong>: you can no longer attach a client policy to a <code>VirtualService</code></li> </ul> <h3>Features</h3> <ul> <li><strong>appmesh:</strong> add missing route match features (<a href="https://github.com/aws/aws-cdk/issues/13350">#13350</a>) (<a href="https://github.com/aws/aws-cdk/commit/b71efd9d12843ab4b495d53e565cec97d60748f3">b71efd9</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11645">#11645</a></li> <li><strong>aws-elasticloadbalancingv2:</strong> add protocol version for ALB TargetGroups (<a href="https://github.com/aws/aws-cdk/issues/13570">#13570</a>) (<a href="https://github.com/aws/aws-cdk/commit/165a3d877b7ab23f29e42e1e74ee7c5cb35b7f24">165a3d8</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12869">#12869</a></li> <li><strong>ecs-patterns:</strong> Add ECS deployment circuit breaker support to higher-level constructs (<a href="https://github.com/aws/aws-cdk/issues/12719">#12719</a>) (<a href="https://github.com/aws/aws-cdk/commit/e80a98aa8839e9b9b89701158d82b991e9ebaa65">e80a98a</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12534">#12534</a> <a href="https://github.com/aws/aws-cdk/issues/12360">#12360</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>appmesh:</strong> Move Client Policy from Virtual Service to backend structure (<a href="https://github.com/aws/aws-cdk/issues/12943">#12943</a>) (<a href="https://github.com/aws/aws-cdk/commit/d3f428435976c55ca950279cfc841665fd504370">d3f4284</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11996">#11996</a></li> <li><strong>autoscaling:</strong> AutoScaling on percentile metrics doesn't work (<a href="https://github.com/aws/aws-cdk/issues/13366">#13366</a>) (<a href="https://github.com/aws/aws-cdk/commit/46114bb1f4702019a8873b9162d0a9f10763bc61">46114bb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13144">#13144</a></li> <li><strong>cloudwatch:</strong> cannot create Alarms from labeled metrics that start with a digit (<a href="https://github.com/aws/aws-cdk/issues/13560">#13560</a>) (<a href="https://github.com/aws/aws-cdk/commit/278029f25b41d956091835364e5a8de91429712c">278029f</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13434">#13434</a></li> <li>use NodeJS 14 for all packaged custom resources (<a href="https://github.com/aws/aws-cdk/issues/13488">#13488</a>) (<a href="https://github.com/aws/aws-cdk/commit/20a2820ee4d022663fcd0928fbc0f61153ae953f">20a2820</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13534">#13534</a> <a href="https://github.com/aws/aws-cdk/issues/13484">#13484</a></li> <li><strong>ec2:</strong> Security Groups support all protocols (<a href="https://github.com/aws/aws-cdk/issues/13593">#13593</a>) (<a href="https://github.com/aws/aws-cdk/commit/8c6b3ebea464e27f68ffcab32857d8baec29c413">8c6b3eb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13403">#13403</a></li> <li><strong>lambda:</strong> fromDockerBuild output is located under /asset (<a href="https://github.com/aws/aws-cdk/issues/13539">#13539</a>) (<a href="https://github.com/aws/aws-cdk/commit/77449f61e7075fef1240fc52becb8ea60b9ea9ad">77449f6</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13439">#13439</a></li> <li><strong>region-info:</strong> ap-northeast-3 data not correctly registered (<a href="https://github.com/aws/aws-cdk/issues/13564">#13564</a>) (<a href="https://github.com/aws/aws-cdk/commit/64da84be5c60bb8132551bcc27a7ca9c7effe95d">64da84b</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13561">#13561</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-cdk/blob/master/CHANGELOG.md"><code>@aws-cdk/core's changelog</code></a>.</em></p> <blockquote> <h2><a href="https://github.com/aws/aws-cdk/compare/v1.94.0...v1.94.1">1.94.1</a> (2021-03-16)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>s3:</strong> Notifications fail to deploy due to incompatible node runtime (<a href="https://github.com/aws/aws-cdk/issues/13624">#13624</a>) (<a href="https://github.com/aws/aws-cdk/commit/26bc3d4951a96a4bdf3e3e10464a4e3b80ed563f">26bc3d4</a>)</li> </ul> <h2><a href="https://github.com/aws/aws-cdk/compare/v1.93.0...v1.94.0">1.94.0</a> (2021-03-16)</h2> <h3>⚠ BREAKING CHANGES TO EXPERIMENTAL FEATURES</h3> <ul> <li><strong>appmesh:</strong> Backend, backend default and Virtual Service client policies structures are being altered</li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualGateway</code>. The property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code></li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualNode</code>, (the property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code>), and the <code>Backend</code> class to define a backend</li> <li><strong>appmesh</strong>: you can no longer attach a client policy to a <code>VirtualService</code></li> </ul> <h3>Features</h3> <ul> <li><strong>appmesh:</strong> add missing route match features (<a href="https://github.com/aws/aws-cdk/issues/13350">#13350</a>) (<a href="https://github.com/aws/aws-cdk/commit/b71efd9d12843ab4b495d53e565cec97d60748f3">b71efd9</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11645">#11645</a></li> <li><strong>aws-elasticloadbalancingv2:</strong> add protocol version for ALB TargetGroups (<a href="https://github.com/aws/aws-cdk/issues/13570">#13570</a>) (<a href="https://github.com/aws/aws-cdk/commit/165a3d877b7ab23f29e42e1e74ee7c5cb35b7f24">165a3d8</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12869">#12869</a></li> <li><strong>ecs-patterns:</strong> Add ECS deployment circuit breaker support to higher-level constructs (<a href="https://github.com/aws/aws-cdk/issues/12719">#12719</a>) (<a href="https://github.com/aws/aws-cdk/commit/e80a98aa8839e9b9b89701158d82b991e9ebaa65">e80a98a</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12534">#12534</a> <a href="https://github.com/aws/aws-cdk/issues/12360">#12360</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>appmesh:</strong> Move Client Policy from Virtual Service to backend structure (<a href="https://github.com/aws/aws-cdk/issues/12943">#12943</a>) (<a href="https://github.com/aws/aws-cdk/commit/d3f428435976c55ca950279cfc841665fd504370">d3f4284</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11996">#11996</a></li> <li><strong>autoscaling:</strong> AutoScaling on percentile metrics doesn't work (<a href="https://github.com/aws/aws-cdk/issues/13366">#13366</a>) (<a href="https://github.com/aws/aws-cdk/commit/46114bb1f4702019a8873b9162d0a9f10763bc61">46114bb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13144">#13144</a></li> <li><strong>cloudwatch:</strong> cannot create Alarms from labeled metrics that start with a digit (<a href="https://github.com/aws/aws-cdk/issues/13560">#13560</a>) (<a href="https://github.com/aws/aws-cdk/commit/278029f25b41d956091835364e5a8de91429712c">278029f</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13434">#13434</a></li> <li>use NodeJS 14 for all packaged custom resources (<a href="https://github.com/aws/aws-cdk/issues/13488">#13488</a>) (<a href="https://github.com/aws/aws-cdk/commit/20a2820ee4d022663fcd0928fbc0f61153ae953f">20a2820</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13534">#13534</a> <a href="https://github.com/aws/aws-cdk/issues/13484">#13484</a></li> <li><strong>ec2:</strong> Security Groups support all protocols (<a href="https://github.com/aws/aws-cdk/issues/13593">#13593</a>) (<a href="https://github.com/aws/aws-cdk/commit/8c6b3ebea464e27f68ffcab32857d8baec29c413">8c6b3eb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13403">#13403</a></li> <li><strong>lambda:</strong> fromDockerBuild output is located under /asset (<a href="https://github.com/aws/aws-cdk/issues/13539">#13539</a>) (<a href="https://github.com/aws/aws-cdk/commit/77449f61e7075fef1240fc52becb8ea60b9ea9ad">77449f6</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13439">#13439</a></li> <li><strong>region-info:</strong> ap-northeast-3 data not correctly registered (<a href="https://github.com/aws/aws-cdk/issues/13564">#13564</a>) (<a href="https://github.com/aws/aws-cdk/commit/64da84be5c60bb8132551bcc27a7ca9c7effe95d">64da84b</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13561">#13561</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/aws/aws-cdk/commits/v1.94.1/packages/@aws-cdk/core">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually </details>
mergify bot
added a commit
to wchaws/effective-cdk
that referenced
this pull request
Mar 17, 2021
[//]: # (dependabot-start)⚠️ **Dependabot is rebasing this PR**⚠️ If you make any changes to it yourself then they will take precedence over the rebase. --- [//]: # (dependabot-end) Bumps [@aws-cdk/aws-lambda](https://github.com/aws/aws-cdk/tree/HEAD/packages/@aws-cdk/aws-lambda) from 1.93.0 to 1.94.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-cdk/releases"><code>@aws-cdk/aws-lambda's releases</code></a>.</em></p> <blockquote> <h2>v1.94.1</h2> <h3>Bug Fixes</h3> <ul> <li><strong>s3:</strong> Notifications fail to deploy due to incompatible node runtime (<a href="https://github.com/aws/aws-cdk/issues/13624">#13624</a>) (<a href="https://github.com/aws/aws-cdk/commit/26bc3d4951a96a4bdf3e3e10464a4e3b80ed563f">26bc3d4</a>)</li> </ul> <h2>v1.94.0</h2> <h3>⚠ BREAKING CHANGES TO EXPERIMENTAL FEATURES</h3> <ul> <li><strong>appmesh:</strong> Backend, backend default and Virtual Service client policies structures are being altered</li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualGateway</code>. The property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code></li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualNode</code>, (the property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code>), and the <code>Backend</code> class to define a backend</li> <li><strong>appmesh</strong>: you can no longer attach a client policy to a <code>VirtualService</code></li> </ul> <h3>Features</h3> <ul> <li><strong>appmesh:</strong> add missing route match features (<a href="https://github.com/aws/aws-cdk/issues/13350">#13350</a>) (<a href="https://github.com/aws/aws-cdk/commit/b71efd9d12843ab4b495d53e565cec97d60748f3">b71efd9</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11645">#11645</a></li> <li><strong>aws-elasticloadbalancingv2:</strong> add protocol version for ALB TargetGroups (<a href="https://github.com/aws/aws-cdk/issues/13570">#13570</a>) (<a href="https://github.com/aws/aws-cdk/commit/165a3d877b7ab23f29e42e1e74ee7c5cb35b7f24">165a3d8</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12869">#12869</a></li> <li><strong>ecs-patterns:</strong> Add ECS deployment circuit breaker support to higher-level constructs (<a href="https://github.com/aws/aws-cdk/issues/12719">#12719</a>) (<a href="https://github.com/aws/aws-cdk/commit/e80a98aa8839e9b9b89701158d82b991e9ebaa65">e80a98a</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12534">#12534</a> <a href="https://github.com/aws/aws-cdk/issues/12360">#12360</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>appmesh:</strong> Move Client Policy from Virtual Service to backend structure (<a href="https://github.com/aws/aws-cdk/issues/12943">#12943</a>) (<a href="https://github.com/aws/aws-cdk/commit/d3f428435976c55ca950279cfc841665fd504370">d3f4284</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11996">#11996</a></li> <li><strong>autoscaling:</strong> AutoScaling on percentile metrics doesn't work (<a href="https://github.com/aws/aws-cdk/issues/13366">#13366</a>) (<a href="https://github.com/aws/aws-cdk/commit/46114bb1f4702019a8873b9162d0a9f10763bc61">46114bb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13144">#13144</a></li> <li><strong>cloudwatch:</strong> cannot create Alarms from labeled metrics that start with a digit (<a href="https://github.com/aws/aws-cdk/issues/13560">#13560</a>) (<a href="https://github.com/aws/aws-cdk/commit/278029f25b41d956091835364e5a8de91429712c">278029f</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13434">#13434</a></li> <li>use NodeJS 14 for all packaged custom resources (<a href="https://github.com/aws/aws-cdk/issues/13488">#13488</a>) (<a href="https://github.com/aws/aws-cdk/commit/20a2820ee4d022663fcd0928fbc0f61153ae953f">20a2820</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13534">#13534</a> <a href="https://github.com/aws/aws-cdk/issues/13484">#13484</a></li> <li><strong>ec2:</strong> Security Groups support all protocols (<a href="https://github.com/aws/aws-cdk/issues/13593">#13593</a>) (<a href="https://github.com/aws/aws-cdk/commit/8c6b3ebea464e27f68ffcab32857d8baec29c413">8c6b3eb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13403">#13403</a></li> <li><strong>lambda:</strong> fromDockerBuild output is located under /asset (<a href="https://github.com/aws/aws-cdk/issues/13539">#13539</a>) (<a href="https://github.com/aws/aws-cdk/commit/77449f61e7075fef1240fc52becb8ea60b9ea9ad">77449f6</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13439">#13439</a></li> <li><strong>region-info:</strong> ap-northeast-3 data not correctly registered (<a href="https://github.com/aws/aws-cdk/issues/13564">#13564</a>) (<a href="https://github.com/aws/aws-cdk/commit/64da84be5c60bb8132551bcc27a7ca9c7effe95d">64da84b</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13561">#13561</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-cdk/blob/master/CHANGELOG.md"><code>@aws-cdk/aws-lambda's changelog</code></a>.</em></p> <blockquote> <h2><a href="https://github.com/aws/aws-cdk/compare/v1.94.0...v1.94.1">1.94.1</a> (2021-03-16)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>s3:</strong> Notifications fail to deploy due to incompatible node runtime (<a href="https://github.com/aws/aws-cdk/issues/13624">#13624</a>) (<a href="https://github.com/aws/aws-cdk/commit/26bc3d4951a96a4bdf3e3e10464a4e3b80ed563f">26bc3d4</a>)</li> </ul> <h2><a href="https://github.com/aws/aws-cdk/compare/v1.93.0...v1.94.0">1.94.0</a> (2021-03-16)</h2> <h3>⚠ BREAKING CHANGES TO EXPERIMENTAL FEATURES</h3> <ul> <li><strong>appmesh:</strong> Backend, backend default and Virtual Service client policies structures are being altered</li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualGateway</code>. The property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code></li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualNode</code>, (the property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code>), and the <code>Backend</code> class to define a backend</li> <li><strong>appmesh</strong>: you can no longer attach a client policy to a <code>VirtualService</code></li> </ul> <h3>Features</h3> <ul> <li><strong>appmesh:</strong> add missing route match features (<a href="https://github.com/aws/aws-cdk/issues/13350">#13350</a>) (<a href="https://github.com/aws/aws-cdk/commit/b71efd9d12843ab4b495d53e565cec97d60748f3">b71efd9</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11645">#11645</a></li> <li><strong>aws-elasticloadbalancingv2:</strong> add protocol version for ALB TargetGroups (<a href="https://github.com/aws/aws-cdk/issues/13570">#13570</a>) (<a href="https://github.com/aws/aws-cdk/commit/165a3d877b7ab23f29e42e1e74ee7c5cb35b7f24">165a3d8</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12869">#12869</a></li> <li><strong>ecs-patterns:</strong> Add ECS deployment circuit breaker support to higher-level constructs (<a href="https://github.com/aws/aws-cdk/issues/12719">#12719</a>) (<a href="https://github.com/aws/aws-cdk/commit/e80a98aa8839e9b9b89701158d82b991e9ebaa65">e80a98a</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12534">#12534</a> <a href="https://github.com/aws/aws-cdk/issues/12360">#12360</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>appmesh:</strong> Move Client Policy from Virtual Service to backend structure (<a href="https://github.com/aws/aws-cdk/issues/12943">#12943</a>) (<a href="https://github.com/aws/aws-cdk/commit/d3f428435976c55ca950279cfc841665fd504370">d3f4284</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11996">#11996</a></li> <li><strong>autoscaling:</strong> AutoScaling on percentile metrics doesn't work (<a href="https://github.com/aws/aws-cdk/issues/13366">#13366</a>) (<a href="https://github.com/aws/aws-cdk/commit/46114bb1f4702019a8873b9162d0a9f10763bc61">46114bb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13144">#13144</a></li> <li><strong>cloudwatch:</strong> cannot create Alarms from labeled metrics that start with a digit (<a href="https://github.com/aws/aws-cdk/issues/13560">#13560</a>) (<a href="https://github.com/aws/aws-cdk/commit/278029f25b41d956091835364e5a8de91429712c">278029f</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13434">#13434</a></li> <li>use NodeJS 14 for all packaged custom resources (<a href="https://github.com/aws/aws-cdk/issues/13488">#13488</a>) (<a href="https://github.com/aws/aws-cdk/commit/20a2820ee4d022663fcd0928fbc0f61153ae953f">20a2820</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13534">#13534</a> <a href="https://github.com/aws/aws-cdk/issues/13484">#13484</a></li> <li><strong>ec2:</strong> Security Groups support all protocols (<a href="https://github.com/aws/aws-cdk/issues/13593">#13593</a>) (<a href="https://github.com/aws/aws-cdk/commit/8c6b3ebea464e27f68ffcab32857d8baec29c413">8c6b3eb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13403">#13403</a></li> <li><strong>lambda:</strong> fromDockerBuild output is located under /asset (<a href="https://github.com/aws/aws-cdk/issues/13539">#13539</a>) (<a href="https://github.com/aws/aws-cdk/commit/77449f61e7075fef1240fc52becb8ea60b9ea9ad">77449f6</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13439">#13439</a></li> <li><strong>region-info:</strong> ap-northeast-3 data not correctly registered (<a href="https://github.com/aws/aws-cdk/issues/13564">#13564</a>) (<a href="https://github.com/aws/aws-cdk/commit/64da84be5c60bb8132551bcc27a7ca9c7effe95d">64da84b</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13561">#13561</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/aws/aws-cdk/commit/81cf548b115e0e65d8dedf54d3efabdcbfda536b"><code>81cf548</code></a> chore(docs): fix typos across the board (<a href="https://github.com/aws/aws-cdk/tree/HEAD/packages/@aws-cdk/aws-lambda/issues/13435">#13435</a>)</li> <li><a href="https://github.com/aws/aws-cdk/commit/77449f61e7075fef1240fc52becb8ea60b9ea9ad"><code>77449f6</code></a> fix(lambda): fromDockerBuild output is located under /asset (<a href="https://github.com/aws/aws-cdk/tree/HEAD/packages/@aws-cdk/aws-lambda/issues/13539">#13539</a>)</li> <li>See full diff in <a href="https://github.com/aws/aws-cdk/commits/v1.94.1/packages/@aws-cdk/aws-lambda">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually </details>
mergify bot
added a commit
to wchaws/effective-cdk
that referenced
this pull request
Mar 17, 2021
[//]: # (dependabot-start)⚠️ **Dependabot is rebasing this PR**⚠️ If you make any changes to it yourself then they will take precedence over the rebase. --- [//]: # (dependabot-end) Bumps [aws-cdk](https://github.com/aws/aws-cdk/tree/HEAD/packages/aws-cdk) from 1.93.0 to 1.94.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-cdk/releases">aws-cdk's releases</a>.</em></p> <blockquote> <h2>v1.94.1</h2> <h3>Bug Fixes</h3> <ul> <li><strong>s3:</strong> Notifications fail to deploy due to incompatible node runtime (<a href="https://github.com/aws/aws-cdk/issues/13624">#13624</a>) (<a href="https://github.com/aws/aws-cdk/commit/26bc3d4951a96a4bdf3e3e10464a4e3b80ed563f">26bc3d4</a>)</li> </ul> <h2>v1.94.0</h2> <h3>⚠ BREAKING CHANGES TO EXPERIMENTAL FEATURES</h3> <ul> <li><strong>appmesh:</strong> Backend, backend default and Virtual Service client policies structures are being altered</li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualGateway</code>. The property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code></li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualNode</code>, (the property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code>), and the <code>Backend</code> class to define a backend</li> <li><strong>appmesh</strong>: you can no longer attach a client policy to a <code>VirtualService</code></li> </ul> <h3>Features</h3> <ul> <li><strong>appmesh:</strong> add missing route match features (<a href="https://github.com/aws/aws-cdk/issues/13350">#13350</a>) (<a href="https://github.com/aws/aws-cdk/commit/b71efd9d12843ab4b495d53e565cec97d60748f3">b71efd9</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11645">#11645</a></li> <li><strong>aws-elasticloadbalancingv2:</strong> add protocol version for ALB TargetGroups (<a href="https://github.com/aws/aws-cdk/issues/13570">#13570</a>) (<a href="https://github.com/aws/aws-cdk/commit/165a3d877b7ab23f29e42e1e74ee7c5cb35b7f24">165a3d8</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12869">#12869</a></li> <li><strong>ecs-patterns:</strong> Add ECS deployment circuit breaker support to higher-level constructs (<a href="https://github.com/aws/aws-cdk/issues/12719">#12719</a>) (<a href="https://github.com/aws/aws-cdk/commit/e80a98aa8839e9b9b89701158d82b991e9ebaa65">e80a98a</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12534">#12534</a> <a href="https://github.com/aws/aws-cdk/issues/12360">#12360</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>appmesh:</strong> Move Client Policy from Virtual Service to backend structure (<a href="https://github.com/aws/aws-cdk/issues/12943">#12943</a>) (<a href="https://github.com/aws/aws-cdk/commit/d3f428435976c55ca950279cfc841665fd504370">d3f4284</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11996">#11996</a></li> <li><strong>autoscaling:</strong> AutoScaling on percentile metrics doesn't work (<a href="https://github.com/aws/aws-cdk/issues/13366">#13366</a>) (<a href="https://github.com/aws/aws-cdk/commit/46114bb1f4702019a8873b9162d0a9f10763bc61">46114bb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13144">#13144</a></li> <li><strong>cloudwatch:</strong> cannot create Alarms from labeled metrics that start with a digit (<a href="https://github.com/aws/aws-cdk/issues/13560">#13560</a>) (<a href="https://github.com/aws/aws-cdk/commit/278029f25b41d956091835364e5a8de91429712c">278029f</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13434">#13434</a></li> <li>use NodeJS 14 for all packaged custom resources (<a href="https://github.com/aws/aws-cdk/issues/13488">#13488</a>) (<a href="https://github.com/aws/aws-cdk/commit/20a2820ee4d022663fcd0928fbc0f61153ae953f">20a2820</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13534">#13534</a> <a href="https://github.com/aws/aws-cdk/issues/13484">#13484</a></li> <li><strong>ec2:</strong> Security Groups support all protocols (<a href="https://github.com/aws/aws-cdk/issues/13593">#13593</a>) (<a href="https://github.com/aws/aws-cdk/commit/8c6b3ebea464e27f68ffcab32857d8baec29c413">8c6b3eb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13403">#13403</a></li> <li><strong>lambda:</strong> fromDockerBuild output is located under /asset (<a href="https://github.com/aws/aws-cdk/issues/13539">#13539</a>) (<a href="https://github.com/aws/aws-cdk/commit/77449f61e7075fef1240fc52becb8ea60b9ea9ad">77449f6</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13439">#13439</a></li> <li><strong>region-info:</strong> ap-northeast-3 data not correctly registered (<a href="https://github.com/aws/aws-cdk/issues/13564">#13564</a>) (<a href="https://github.com/aws/aws-cdk/commit/64da84be5c60bb8132551bcc27a7ca9c7effe95d">64da84b</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13561">#13561</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-cdk/blob/master/CHANGELOG.md">aws-cdk's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/aws/aws-cdk/compare/v1.94.0...v1.94.1">1.94.1</a> (2021-03-16)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>s3:</strong> Notifications fail to deploy due to incompatible node runtime (<a href="https://github.com/aws/aws-cdk/issues/13624">#13624</a>) (<a href="https://github.com/aws/aws-cdk/commit/26bc3d4951a96a4bdf3e3e10464a4e3b80ed563f">26bc3d4</a>)</li> </ul> <h2><a href="https://github.com/aws/aws-cdk/compare/v1.93.0...v1.94.0">1.94.0</a> (2021-03-16)</h2> <h3>⚠ BREAKING CHANGES TO EXPERIMENTAL FEATURES</h3> <ul> <li><strong>appmesh:</strong> Backend, backend default and Virtual Service client policies structures are being altered</li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualGateway</code>. The property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code></li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualNode</code>, (the property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code>), and the <code>Backend</code> class to define a backend</li> <li><strong>appmesh</strong>: you can no longer attach a client policy to a <code>VirtualService</code></li> </ul> <h3>Features</h3> <ul> <li><strong>appmesh:</strong> add missing route match features (<a href="https://github.com/aws/aws-cdk/issues/13350">#13350</a>) (<a href="https://github.com/aws/aws-cdk/commit/b71efd9d12843ab4b495d53e565cec97d60748f3">b71efd9</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11645">#11645</a></li> <li><strong>aws-elasticloadbalancingv2:</strong> add protocol version for ALB TargetGroups (<a href="https://github.com/aws/aws-cdk/issues/13570">#13570</a>) (<a href="https://github.com/aws/aws-cdk/commit/165a3d877b7ab23f29e42e1e74ee7c5cb35b7f24">165a3d8</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12869">#12869</a></li> <li><strong>ecs-patterns:</strong> Add ECS deployment circuit breaker support to higher-level constructs (<a href="https://github.com/aws/aws-cdk/issues/12719">#12719</a>) (<a href="https://github.com/aws/aws-cdk/commit/e80a98aa8839e9b9b89701158d82b991e9ebaa65">e80a98a</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12534">#12534</a> <a href="https://github.com/aws/aws-cdk/issues/12360">#12360</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>appmesh:</strong> Move Client Policy from Virtual Service to backend structure (<a href="https://github.com/aws/aws-cdk/issues/12943">#12943</a>) (<a href="https://github.com/aws/aws-cdk/commit/d3f428435976c55ca950279cfc841665fd504370">d3f4284</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11996">#11996</a></li> <li><strong>autoscaling:</strong> AutoScaling on percentile metrics doesn't work (<a href="https://github.com/aws/aws-cdk/issues/13366">#13366</a>) (<a href="https://github.com/aws/aws-cdk/commit/46114bb1f4702019a8873b9162d0a9f10763bc61">46114bb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13144">#13144</a></li> <li><strong>cloudwatch:</strong> cannot create Alarms from labeled metrics that start with a digit (<a href="https://github.com/aws/aws-cdk/issues/13560">#13560</a>) (<a href="https://github.com/aws/aws-cdk/commit/278029f25b41d956091835364e5a8de91429712c">278029f</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13434">#13434</a></li> <li>use NodeJS 14 for all packaged custom resources (<a href="https://github.com/aws/aws-cdk/issues/13488">#13488</a>) (<a href="https://github.com/aws/aws-cdk/commit/20a2820ee4d022663fcd0928fbc0f61153ae953f">20a2820</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13534">#13534</a> <a href="https://github.com/aws/aws-cdk/issues/13484">#13484</a></li> <li><strong>ec2:</strong> Security Groups support all protocols (<a href="https://github.com/aws/aws-cdk/issues/13593">#13593</a>) (<a href="https://github.com/aws/aws-cdk/commit/8c6b3ebea464e27f68ffcab32857d8baec29c413">8c6b3eb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13403">#13403</a></li> <li><strong>lambda:</strong> fromDockerBuild output is located under /asset (<a href="https://github.com/aws/aws-cdk/issues/13539">#13539</a>) (<a href="https://github.com/aws/aws-cdk/commit/77449f61e7075fef1240fc52becb8ea60b9ea9ad">77449f6</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13439">#13439</a></li> <li><strong>region-info:</strong> ap-northeast-3 data not correctly registered (<a href="https://github.com/aws/aws-cdk/issues/13564">#13564</a>) (<a href="https://github.com/aws/aws-cdk/commit/64da84be5c60bb8132551bcc27a7ca9c7effe95d">64da84b</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13561">#13561</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/aws/aws-cdk/commits/v1.94.1/packages/aws-cdk">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually </details>
mergify bot
added a commit
to wchaws/effective-cdk
that referenced
this pull request
Mar 17, 2021
[//]: # (dependabot-start)⚠️ **Dependabot is rebasing this PR**⚠️ If you make any changes to it yourself then they will take precedence over the rebase. --- [//]: # (dependabot-end) Bumps [@aws-cdk/assert](https://github.com/aws/aws-cdk/tree/HEAD/packages/@aws-cdk/assert) from 1.93.0 to 1.94.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-cdk/releases"><code>@aws-cdk/assert's releases</code></a>.</em></p> <blockquote> <h2>v1.94.1</h2> <h3>Bug Fixes</h3> <ul> <li><strong>s3:</strong> Notifications fail to deploy due to incompatible node runtime (<a href="https://github.com/aws/aws-cdk/issues/13624">#13624</a>) (<a href="https://github.com/aws/aws-cdk/commit/26bc3d4951a96a4bdf3e3e10464a4e3b80ed563f">26bc3d4</a>)</li> </ul> <h2>v1.94.0</h2> <h3>⚠ BREAKING CHANGES TO EXPERIMENTAL FEATURES</h3> <ul> <li><strong>appmesh:</strong> Backend, backend default and Virtual Service client policies structures are being altered</li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualGateway</code>. The property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code></li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualNode</code>, (the property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code>), and the <code>Backend</code> class to define a backend</li> <li><strong>appmesh</strong>: you can no longer attach a client policy to a <code>VirtualService</code></li> </ul> <h3>Features</h3> <ul> <li><strong>appmesh:</strong> add missing route match features (<a href="https://github.com/aws/aws-cdk/issues/13350">#13350</a>) (<a href="https://github.com/aws/aws-cdk/commit/b71efd9d12843ab4b495d53e565cec97d60748f3">b71efd9</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11645">#11645</a></li> <li><strong>aws-elasticloadbalancingv2:</strong> add protocol version for ALB TargetGroups (<a href="https://github.com/aws/aws-cdk/issues/13570">#13570</a>) (<a href="https://github.com/aws/aws-cdk/commit/165a3d877b7ab23f29e42e1e74ee7c5cb35b7f24">165a3d8</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12869">#12869</a></li> <li><strong>ecs-patterns:</strong> Add ECS deployment circuit breaker support to higher-level constructs (<a href="https://github.com/aws/aws-cdk/issues/12719">#12719</a>) (<a href="https://github.com/aws/aws-cdk/commit/e80a98aa8839e9b9b89701158d82b991e9ebaa65">e80a98a</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12534">#12534</a> <a href="https://github.com/aws/aws-cdk/issues/12360">#12360</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>appmesh:</strong> Move Client Policy from Virtual Service to backend structure (<a href="https://github.com/aws/aws-cdk/issues/12943">#12943</a>) (<a href="https://github.com/aws/aws-cdk/commit/d3f428435976c55ca950279cfc841665fd504370">d3f4284</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11996">#11996</a></li> <li><strong>autoscaling:</strong> AutoScaling on percentile metrics doesn't work (<a href="https://github.com/aws/aws-cdk/issues/13366">#13366</a>) (<a href="https://github.com/aws/aws-cdk/commit/46114bb1f4702019a8873b9162d0a9f10763bc61">46114bb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13144">#13144</a></li> <li><strong>cloudwatch:</strong> cannot create Alarms from labeled metrics that start with a digit (<a href="https://github.com/aws/aws-cdk/issues/13560">#13560</a>) (<a href="https://github.com/aws/aws-cdk/commit/278029f25b41d956091835364e5a8de91429712c">278029f</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13434">#13434</a></li> <li>use NodeJS 14 for all packaged custom resources (<a href="https://github.com/aws/aws-cdk/issues/13488">#13488</a>) (<a href="https://github.com/aws/aws-cdk/commit/20a2820ee4d022663fcd0928fbc0f61153ae953f">20a2820</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13534">#13534</a> <a href="https://github.com/aws/aws-cdk/issues/13484">#13484</a></li> <li><strong>ec2:</strong> Security Groups support all protocols (<a href="https://github.com/aws/aws-cdk/issues/13593">#13593</a>) (<a href="https://github.com/aws/aws-cdk/commit/8c6b3ebea464e27f68ffcab32857d8baec29c413">8c6b3eb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13403">#13403</a></li> <li><strong>lambda:</strong> fromDockerBuild output is located under /asset (<a href="https://github.com/aws/aws-cdk/issues/13539">#13539</a>) (<a href="https://github.com/aws/aws-cdk/commit/77449f61e7075fef1240fc52becb8ea60b9ea9ad">77449f6</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13439">#13439</a></li> <li><strong>region-info:</strong> ap-northeast-3 data not correctly registered (<a href="https://github.com/aws/aws-cdk/issues/13564">#13564</a>) (<a href="https://github.com/aws/aws-cdk/commit/64da84be5c60bb8132551bcc27a7ca9c7effe95d">64da84b</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13561">#13561</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-cdk/blob/master/CHANGELOG.md"><code>@aws-cdk/assert's changelog</code></a>.</em></p> <blockquote> <h2><a href="https://github.com/aws/aws-cdk/compare/v1.94.0...v1.94.1">1.94.1</a> (2021-03-16)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>s3:</strong> Notifications fail to deploy due to incompatible node runtime (<a href="https://github.com/aws/aws-cdk/issues/13624">#13624</a>) (<a href="https://github.com/aws/aws-cdk/commit/26bc3d4951a96a4bdf3e3e10464a4e3b80ed563f">26bc3d4</a>)</li> </ul> <h2><a href="https://github.com/aws/aws-cdk/compare/v1.93.0...v1.94.0">1.94.0</a> (2021-03-16)</h2> <h3>⚠ BREAKING CHANGES TO EXPERIMENTAL FEATURES</h3> <ul> <li><strong>appmesh:</strong> Backend, backend default and Virtual Service client policies structures are being altered</li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualGateway</code>. The property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code></li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualNode</code>, (the property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code>), and the <code>Backend</code> class to define a backend</li> <li><strong>appmesh</strong>: you can no longer attach a client policy to a <code>VirtualService</code></li> </ul> <h3>Features</h3> <ul> <li><strong>appmesh:</strong> add missing route match features (<a href="https://github.com/aws/aws-cdk/issues/13350">#13350</a>) (<a href="https://github.com/aws/aws-cdk/commit/b71efd9d12843ab4b495d53e565cec97d60748f3">b71efd9</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11645">#11645</a></li> <li><strong>aws-elasticloadbalancingv2:</strong> add protocol version for ALB TargetGroups (<a href="https://github.com/aws/aws-cdk/issues/13570">#13570</a>) (<a href="https://github.com/aws/aws-cdk/commit/165a3d877b7ab23f29e42e1e74ee7c5cb35b7f24">165a3d8</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12869">#12869</a></li> <li><strong>ecs-patterns:</strong> Add ECS deployment circuit breaker support to higher-level constructs (<a href="https://github.com/aws/aws-cdk/issues/12719">#12719</a>) (<a href="https://github.com/aws/aws-cdk/commit/e80a98aa8839e9b9b89701158d82b991e9ebaa65">e80a98a</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12534">#12534</a> <a href="https://github.com/aws/aws-cdk/issues/12360">#12360</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>appmesh:</strong> Move Client Policy from Virtual Service to backend structure (<a href="https://github.com/aws/aws-cdk/issues/12943">#12943</a>) (<a href="https://github.com/aws/aws-cdk/commit/d3f428435976c55ca950279cfc841665fd504370">d3f4284</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11996">#11996</a></li> <li><strong>autoscaling:</strong> AutoScaling on percentile metrics doesn't work (<a href="https://github.com/aws/aws-cdk/issues/13366">#13366</a>) (<a href="https://github.com/aws/aws-cdk/commit/46114bb1f4702019a8873b9162d0a9f10763bc61">46114bb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13144">#13144</a></li> <li><strong>cloudwatch:</strong> cannot create Alarms from labeled metrics that start with a digit (<a href="https://github.com/aws/aws-cdk/issues/13560">#13560</a>) (<a href="https://github.com/aws/aws-cdk/commit/278029f25b41d956091835364e5a8de91429712c">278029f</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13434">#13434</a></li> <li>use NodeJS 14 for all packaged custom resources (<a href="https://github.com/aws/aws-cdk/issues/13488">#13488</a>) (<a href="https://github.com/aws/aws-cdk/commit/20a2820ee4d022663fcd0928fbc0f61153ae953f">20a2820</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13534">#13534</a> <a href="https://github.com/aws/aws-cdk/issues/13484">#13484</a></li> <li><strong>ec2:</strong> Security Groups support all protocols (<a href="https://github.com/aws/aws-cdk/issues/13593">#13593</a>) (<a href="https://github.com/aws/aws-cdk/commit/8c6b3ebea464e27f68ffcab32857d8baec29c413">8c6b3eb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13403">#13403</a></li> <li><strong>lambda:</strong> fromDockerBuild output is located under /asset (<a href="https://github.com/aws/aws-cdk/issues/13539">#13539</a>) (<a href="https://github.com/aws/aws-cdk/commit/77449f61e7075fef1240fc52becb8ea60b9ea9ad">77449f6</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13439">#13439</a></li> <li><strong>region-info:</strong> ap-northeast-3 data not correctly registered (<a href="https://github.com/aws/aws-cdk/issues/13564">#13564</a>) (<a href="https://github.com/aws/aws-cdk/commit/64da84be5c60bb8132551bcc27a7ca9c7effe95d">64da84b</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13561">#13561</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/aws/aws-cdk/commits/v1.94.1/packages/@aws-cdk/assert">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually </details>
mergify bot
pushed a commit
to nikovirtala/cdk-preview-environments
that referenced
this pull request
Mar 17, 2021
Bumps [@aws-cdk/assert](https://github.com/aws/aws-cdk/tree/HEAD/packages/@aws-cdk/assert) from 1.93.0 to 1.94.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-cdk/releases"><code>@aws-cdk/assert's releases</code></a>.</em></p> <blockquote> <h2>v1.94.1</h2> <h3>Bug Fixes</h3> <ul> <li><strong>s3:</strong> Notifications fail to deploy due to incompatible node runtime (<a href="https://github.com/aws/aws-cdk/issues/13624">#13624</a>) (<a href="https://github.com/aws/aws-cdk/commit/26bc3d4951a96a4bdf3e3e10464a4e3b80ed563f">26bc3d4</a>)</li> </ul> <h2>v1.94.0</h2> <h3>⚠ BREAKING CHANGES TO EXPERIMENTAL FEATURES</h3> <ul> <li><strong>appmesh:</strong> Backend, backend default and Virtual Service client policies structures are being altered</li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualGateway</code>. The property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code></li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualNode</code>, (the property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code>), and the <code>Backend</code> class to define a backend</li> <li><strong>appmesh</strong>: you can no longer attach a client policy to a <code>VirtualService</code></li> </ul> <h3>Features</h3> <ul> <li><strong>appmesh:</strong> add missing route match features (<a href="https://github.com/aws/aws-cdk/issues/13350">#13350</a>) (<a href="https://github.com/aws/aws-cdk/commit/b71efd9d12843ab4b495d53e565cec97d60748f3">b71efd9</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11645">#11645</a></li> <li><strong>aws-elasticloadbalancingv2:</strong> add protocol version for ALB TargetGroups (<a href="https://github.com/aws/aws-cdk/issues/13570">#13570</a>) (<a href="https://github.com/aws/aws-cdk/commit/165a3d877b7ab23f29e42e1e74ee7c5cb35b7f24">165a3d8</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12869">#12869</a></li> <li><strong>ecs-patterns:</strong> Add ECS deployment circuit breaker support to higher-level constructs (<a href="https://github.com/aws/aws-cdk/issues/12719">#12719</a>) (<a href="https://github.com/aws/aws-cdk/commit/e80a98aa8839e9b9b89701158d82b991e9ebaa65">e80a98a</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12534">#12534</a> <a href="https://github.com/aws/aws-cdk/issues/12360">#12360</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>appmesh:</strong> Move Client Policy from Virtual Service to backend structure (<a href="https://github.com/aws/aws-cdk/issues/12943">#12943</a>) (<a href="https://github.com/aws/aws-cdk/commit/d3f428435976c55ca950279cfc841665fd504370">d3f4284</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11996">#11996</a></li> <li><strong>autoscaling:</strong> AutoScaling on percentile metrics doesn't work (<a href="https://github.com/aws/aws-cdk/issues/13366">#13366</a>) (<a href="https://github.com/aws/aws-cdk/commit/46114bb1f4702019a8873b9162d0a9f10763bc61">46114bb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13144">#13144</a></li> <li><strong>cloudwatch:</strong> cannot create Alarms from labeled metrics that start with a digit (<a href="https://github.com/aws/aws-cdk/issues/13560">#13560</a>) (<a href="https://github.com/aws/aws-cdk/commit/278029f25b41d956091835364e5a8de91429712c">278029f</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13434">#13434</a></li> <li>use NodeJS 14 for all packaged custom resources (<a href="https://github.com/aws/aws-cdk/issues/13488">#13488</a>) (<a href="https://github.com/aws/aws-cdk/commit/20a2820ee4d022663fcd0928fbc0f61153ae953f">20a2820</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13534">#13534</a> <a href="https://github.com/aws/aws-cdk/issues/13484">#13484</a></li> <li><strong>ec2:</strong> Security Groups support all protocols (<a href="https://github.com/aws/aws-cdk/issues/13593">#13593</a>) (<a href="https://github.com/aws/aws-cdk/commit/8c6b3ebea464e27f68ffcab32857d8baec29c413">8c6b3eb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13403">#13403</a></li> <li><strong>lambda:</strong> fromDockerBuild output is located under /asset (<a href="https://github.com/aws/aws-cdk/issues/13539">#13539</a>) (<a href="https://github.com/aws/aws-cdk/commit/77449f61e7075fef1240fc52becb8ea60b9ea9ad">77449f6</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13439">#13439</a></li> <li><strong>region-info:</strong> ap-northeast-3 data not correctly registered (<a href="https://github.com/aws/aws-cdk/issues/13564">#13564</a>) (<a href="https://github.com/aws/aws-cdk/commit/64da84be5c60bb8132551bcc27a7ca9c7effe95d">64da84b</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13561">#13561</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-cdk/blob/master/CHANGELOG.md"><code>@aws-cdk/assert's changelog</code></a>.</em></p> <blockquote> <h2><a href="https://github.com/aws/aws-cdk/compare/v1.94.0...v1.94.1">1.94.1</a> (2021-03-16)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>s3:</strong> Notifications fail to deploy due to incompatible node runtime (<a href="https://github.com/aws/aws-cdk/issues/13624">#13624</a>) (<a href="https://github.com/aws/aws-cdk/commit/26bc3d4951a96a4bdf3e3e10464a4e3b80ed563f">26bc3d4</a>)</li> </ul> <h2><a href="https://github.com/aws/aws-cdk/compare/v1.93.0...v1.94.0">1.94.0</a> (2021-03-16)</h2> <h3>⚠ BREAKING CHANGES TO EXPERIMENTAL FEATURES</h3> <ul> <li><strong>appmesh:</strong> Backend, backend default and Virtual Service client policies structures are being altered</li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualGateway</code>. The property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code></li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualNode</code>, (the property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code>), and the <code>Backend</code> class to define a backend</li> <li><strong>appmesh</strong>: you can no longer attach a client policy to a <code>VirtualService</code></li> </ul> <h3>Features</h3> <ul> <li><strong>appmesh:</strong> add missing route match features (<a href="https://github.com/aws/aws-cdk/issues/13350">#13350</a>) (<a href="https://github.com/aws/aws-cdk/commit/b71efd9d12843ab4b495d53e565cec97d60748f3">b71efd9</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11645">#11645</a></li> <li><strong>aws-elasticloadbalancingv2:</strong> add protocol version for ALB TargetGroups (<a href="https://github.com/aws/aws-cdk/issues/13570">#13570</a>) (<a href="https://github.com/aws/aws-cdk/commit/165a3d877b7ab23f29e42e1e74ee7c5cb35b7f24">165a3d8</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12869">#12869</a></li> <li><strong>ecs-patterns:</strong> Add ECS deployment circuit breaker support to higher-level constructs (<a href="https://github.com/aws/aws-cdk/issues/12719">#12719</a>) (<a href="https://github.com/aws/aws-cdk/commit/e80a98aa8839e9b9b89701158d82b991e9ebaa65">e80a98a</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12534">#12534</a> <a href="https://github.com/aws/aws-cdk/issues/12360">#12360</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>appmesh:</strong> Move Client Policy from Virtual Service to backend structure (<a href="https://github.com/aws/aws-cdk/issues/12943">#12943</a>) (<a href="https://github.com/aws/aws-cdk/commit/d3f428435976c55ca950279cfc841665fd504370">d3f4284</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11996">#11996</a></li> <li><strong>autoscaling:</strong> AutoScaling on percentile metrics doesn't work (<a href="https://github.com/aws/aws-cdk/issues/13366">#13366</a>) (<a href="https://github.com/aws/aws-cdk/commit/46114bb1f4702019a8873b9162d0a9f10763bc61">46114bb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13144">#13144</a></li> <li><strong>cloudwatch:</strong> cannot create Alarms from labeled metrics that start with a digit (<a href="https://github.com/aws/aws-cdk/issues/13560">#13560</a>) (<a href="https://github.com/aws/aws-cdk/commit/278029f25b41d956091835364e5a8de91429712c">278029f</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13434">#13434</a></li> <li>use NodeJS 14 for all packaged custom resources (<a href="https://github.com/aws/aws-cdk/issues/13488">#13488</a>) (<a href="https://github.com/aws/aws-cdk/commit/20a2820ee4d022663fcd0928fbc0f61153ae953f">20a2820</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13534">#13534</a> <a href="https://github.com/aws/aws-cdk/issues/13484">#13484</a></li> <li><strong>ec2:</strong> Security Groups support all protocols (<a href="https://github.com/aws/aws-cdk/issues/13593">#13593</a>) (<a href="https://github.com/aws/aws-cdk/commit/8c6b3ebea464e27f68ffcab32857d8baec29c413">8c6b3eb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13403">#13403</a></li> <li><strong>lambda:</strong> fromDockerBuild output is located under /asset (<a href="https://github.com/aws/aws-cdk/issues/13539">#13539</a>) (<a href="https://github.com/aws/aws-cdk/commit/77449f61e7075fef1240fc52becb8ea60b9ea9ad">77449f6</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13439">#13439</a></li> <li><strong>region-info:</strong> ap-northeast-3 data not correctly registered (<a href="https://github.com/aws/aws-cdk/issues/13564">#13564</a>) (<a href="https://github.com/aws/aws-cdk/commit/64da84be5c60bb8132551bcc27a7ca9c7effe95d">64da84b</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13561">#13561</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/aws/aws-cdk/commits/v1.94.1/packages/@aws-cdk/assert">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually </details>
mergify bot
added a commit
to trexcoe/smile-jenkins
that referenced
this pull request
Mar 17, 2021
Bumps [@aws-cdk/assert](https://github.com/aws/aws-cdk/tree/HEAD/packages/@aws-cdk/assert) from 1.93.0 to 1.94.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-cdk/releases"><code>@aws-cdk/assert's releases</code></a>.</em></p> <blockquote> <h2>v1.94.1</h2> <h3>Bug Fixes</h3> <ul> <li><strong>s3:</strong> Notifications fail to deploy due to incompatible node runtime (<a href="https://github.com/aws/aws-cdk/issues/13624">#13624</a>) (<a href="https://github.com/aws/aws-cdk/commit/26bc3d4951a96a4bdf3e3e10464a4e3b80ed563f">26bc3d4</a>)</li> </ul> <h2>v1.94.0</h2> <h3>⚠ BREAKING CHANGES TO EXPERIMENTAL FEATURES</h3> <ul> <li><strong>appmesh:</strong> Backend, backend default and Virtual Service client policies structures are being altered</li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualGateway</code>. The property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code></li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualNode</code>, (the property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code>), and the <code>Backend</code> class to define a backend</li> <li><strong>appmesh</strong>: you can no longer attach a client policy to a <code>VirtualService</code></li> </ul> <h3>Features</h3> <ul> <li><strong>appmesh:</strong> add missing route match features (<a href="https://github.com/aws/aws-cdk/issues/13350">#13350</a>) (<a href="https://github.com/aws/aws-cdk/commit/b71efd9d12843ab4b495d53e565cec97d60748f3">b71efd9</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11645">#11645</a></li> <li><strong>aws-elasticloadbalancingv2:</strong> add protocol version for ALB TargetGroups (<a href="https://github.com/aws/aws-cdk/issues/13570">#13570</a>) (<a href="https://github.com/aws/aws-cdk/commit/165a3d877b7ab23f29e42e1e74ee7c5cb35b7f24">165a3d8</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12869">#12869</a></li> <li><strong>ecs-patterns:</strong> Add ECS deployment circuit breaker support to higher-level constructs (<a href="https://github.com/aws/aws-cdk/issues/12719">#12719</a>) (<a href="https://github.com/aws/aws-cdk/commit/e80a98aa8839e9b9b89701158d82b991e9ebaa65">e80a98a</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12534">#12534</a> <a href="https://github.com/aws/aws-cdk/issues/12360">#12360</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>appmesh:</strong> Move Client Policy from Virtual Service to backend structure (<a href="https://github.com/aws/aws-cdk/issues/12943">#12943</a>) (<a href="https://github.com/aws/aws-cdk/commit/d3f428435976c55ca950279cfc841665fd504370">d3f4284</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11996">#11996</a></li> <li><strong>autoscaling:</strong> AutoScaling on percentile metrics doesn't work (<a href="https://github.com/aws/aws-cdk/issues/13366">#13366</a>) (<a href="https://github.com/aws/aws-cdk/commit/46114bb1f4702019a8873b9162d0a9f10763bc61">46114bb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13144">#13144</a></li> <li><strong>cloudwatch:</strong> cannot create Alarms from labeled metrics that start with a digit (<a href="https://github.com/aws/aws-cdk/issues/13560">#13560</a>) (<a href="https://github.com/aws/aws-cdk/commit/278029f25b41d956091835364e5a8de91429712c">278029f</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13434">#13434</a></li> <li>use NodeJS 14 for all packaged custom resources (<a href="https://github.com/aws/aws-cdk/issues/13488">#13488</a>) (<a href="https://github.com/aws/aws-cdk/commit/20a2820ee4d022663fcd0928fbc0f61153ae953f">20a2820</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13534">#13534</a> <a href="https://github.com/aws/aws-cdk/issues/13484">#13484</a></li> <li><strong>ec2:</strong> Security Groups support all protocols (<a href="https://github.com/aws/aws-cdk/issues/13593">#13593</a>) (<a href="https://github.com/aws/aws-cdk/commit/8c6b3ebea464e27f68ffcab32857d8baec29c413">8c6b3eb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13403">#13403</a></li> <li><strong>lambda:</strong> fromDockerBuild output is located under /asset (<a href="https://github.com/aws/aws-cdk/issues/13539">#13539</a>) (<a href="https://github.com/aws/aws-cdk/commit/77449f61e7075fef1240fc52becb8ea60b9ea9ad">77449f6</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13439">#13439</a></li> <li><strong>region-info:</strong> ap-northeast-3 data not correctly registered (<a href="https://github.com/aws/aws-cdk/issues/13564">#13564</a>) (<a href="https://github.com/aws/aws-cdk/commit/64da84be5c60bb8132551bcc27a7ca9c7effe95d">64da84b</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13561">#13561</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-cdk/blob/master/CHANGELOG.md"><code>@aws-cdk/assert's changelog</code></a>.</em></p> <blockquote> <h2><a href="https://github.com/aws/aws-cdk/compare/v1.94.0...v1.94.1">1.94.1</a> (2021-03-16)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>s3:</strong> Notifications fail to deploy due to incompatible node runtime (<a href="https://github.com/aws/aws-cdk/issues/13624">#13624</a>) (<a href="https://github.com/aws/aws-cdk/commit/26bc3d4951a96a4bdf3e3e10464a4e3b80ed563f">26bc3d4</a>)</li> </ul> <h2><a href="https://github.com/aws/aws-cdk/compare/v1.93.0...v1.94.0">1.94.0</a> (2021-03-16)</h2> <h3>⚠ BREAKING CHANGES TO EXPERIMENTAL FEATURES</h3> <ul> <li><strong>appmesh:</strong> Backend, backend default and Virtual Service client policies structures are being altered</li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualGateway</code>. The property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code></li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualNode</code>, (the property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code>), and the <code>Backend</code> class to define a backend</li> <li><strong>appmesh</strong>: you can no longer attach a client policy to a <code>VirtualService</code></li> </ul> <h3>Features</h3> <ul> <li><strong>appmesh:</strong> add missing route match features (<a href="https://github.com/aws/aws-cdk/issues/13350">#13350</a>) (<a href="https://github.com/aws/aws-cdk/commit/b71efd9d12843ab4b495d53e565cec97d60748f3">b71efd9</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11645">#11645</a></li> <li><strong>aws-elasticloadbalancingv2:</strong> add protocol version for ALB TargetGroups (<a href="https://github.com/aws/aws-cdk/issues/13570">#13570</a>) (<a href="https://github.com/aws/aws-cdk/commit/165a3d877b7ab23f29e42e1e74ee7c5cb35b7f24">165a3d8</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12869">#12869</a></li> <li><strong>ecs-patterns:</strong> Add ECS deployment circuit breaker support to higher-level constructs (<a href="https://github.com/aws/aws-cdk/issues/12719">#12719</a>) (<a href="https://github.com/aws/aws-cdk/commit/e80a98aa8839e9b9b89701158d82b991e9ebaa65">e80a98a</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12534">#12534</a> <a href="https://github.com/aws/aws-cdk/issues/12360">#12360</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>appmesh:</strong> Move Client Policy from Virtual Service to backend structure (<a href="https://github.com/aws/aws-cdk/issues/12943">#12943</a>) (<a href="https://github.com/aws/aws-cdk/commit/d3f428435976c55ca950279cfc841665fd504370">d3f4284</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11996">#11996</a></li> <li><strong>autoscaling:</strong> AutoScaling on percentile metrics doesn't work (<a href="https://github.com/aws/aws-cdk/issues/13366">#13366</a>) (<a href="https://github.com/aws/aws-cdk/commit/46114bb1f4702019a8873b9162d0a9f10763bc61">46114bb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13144">#13144</a></li> <li><strong>cloudwatch:</strong> cannot create Alarms from labeled metrics that start with a digit (<a href="https://github.com/aws/aws-cdk/issues/13560">#13560</a>) (<a href="https://github.com/aws/aws-cdk/commit/278029f25b41d956091835364e5a8de91429712c">278029f</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13434">#13434</a></li> <li>use NodeJS 14 for all packaged custom resources (<a href="https://github.com/aws/aws-cdk/issues/13488">#13488</a>) (<a href="https://github.com/aws/aws-cdk/commit/20a2820ee4d022663fcd0928fbc0f61153ae953f">20a2820</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13534">#13534</a> <a href="https://github.com/aws/aws-cdk/issues/13484">#13484</a></li> <li><strong>ec2:</strong> Security Groups support all protocols (<a href="https://github.com/aws/aws-cdk/issues/13593">#13593</a>) (<a href="https://github.com/aws/aws-cdk/commit/8c6b3ebea464e27f68ffcab32857d8baec29c413">8c6b3eb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13403">#13403</a></li> <li><strong>lambda:</strong> fromDockerBuild output is located under /asset (<a href="https://github.com/aws/aws-cdk/issues/13539">#13539</a>) (<a href="https://github.com/aws/aws-cdk/commit/77449f61e7075fef1240fc52becb8ea60b9ea9ad">77449f6</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13439">#13439</a></li> <li><strong>region-info:</strong> ap-northeast-3 data not correctly registered (<a href="https://github.com/aws/aws-cdk/issues/13564">#13564</a>) (<a href="https://github.com/aws/aws-cdk/commit/64da84be5c60bb8132551bcc27a7ca9c7effe95d">64da84b</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13561">#13561</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/aws/aws-cdk/commits/v1.94.1/packages/@aws-cdk/assert">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually </details>
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #13434
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license