-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(secretsmanager): Automatically grant permissions to rotation Lambda #14471
feat(secretsmanager): Automatically grant permissions to rotation Lambda #14471
Conversation
When you use the AWS Secrets Manager console to configure rotation for a secret for one of the fully supported databases, the console configures almost all parameters for you. But if you create a function or opt to do anything manually for other reasons, you also might have to manually configure the permissions for that part of the rotation. https://docs.aws.amazon.com/secretsmanager/latest/userguide/rotating-secrets-required-permissions.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks! I'm really shocked this didn't already exist already; perhaps no one has actually ever used the custom rotation function.
I think we can auto-detect the VPC permissions as well (and add a test specific to that); other than that, this looks great.
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…bda (aws#14471) When you use the AWS Secrets Manager console to configure rotation for a secret for one of the fully supported databases, the console configures almost all parameters for you. But if you create a function or opt to do anything manually for other reasons, you also might have to manually configure the permissions for that part of the rotation. https://docs.aws.amazon.com/secretsmanager/latest/userguide/rotating-secrets-required-permissions.html ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
When you use the AWS Secrets Manager console to configure rotation for a
secret for one of the fully supported databases, the console configures
almost all parameters for you. But if you create a function or opt to do
anything manually for other reasons, you also might have to manually
configure the permissions for that part of the rotation.
https://docs.aws.amazon.com/secretsmanager/latest/userguide/rotating-secrets-required-permissions.html
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license