Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@aws-cdk/pipelines. CdkPipeline: Enable multiple sources #14493

Closed
brimock opened this issue May 3, 2021 · 7 comments
Closed

@aws-cdk/pipelines. CdkPipeline: Enable multiple sources #14493

brimock opened this issue May 3, 2021 · 7 comments
Labels
@aws-cdk/pipelines CDK Pipelines library effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1

Comments

@brimock
Copy link

brimock commented May 3, 2021

Currently we can only specify a single source repository for a CdkPipeline, however it would be cleaner to enable us to store different parts of our application in different repositories.

Use Case

I have infrastructure and application code in different repos, and would like to have them deployed within the same pipeline.

Proposed Solution

Change sourceAction to be an array of source actions, i.e. sourceActions

This is a 🚀 Feature Request

@brimock brimock added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 3, 2021
@github-actions github-actions bot added the @aws-cdk/pipelines CDK Pipelines library label May 3, 2021
@bodokaiser
Copy link

Related #14490

@rix0rrr rix0rrr added this to the [GA] CDK Pipelines milestone May 7, 2021
@rix0rrr rix0rrr added p1 effort/small Small work item – less than a day of effort labels May 7, 2021
@ryparker ryparker removed the needs-triage This issue or PR still needs to be triaged. label Jun 1, 2021
@rix0rrr
Copy link
Contributor

rix0rrr commented Jun 30, 2021

Will be addressed by #12326, closing early as duplicate to keep tracking more manageable.

@rix0rrr rix0rrr closed this as completed Jun 30, 2021
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@robert-hanuschke
Copy link

@rix0rrr #12326 is merged now but I think it does not include multiple sources (at least I don't see it in the documentation and couldn't configure it in v1.125.0). Should this be reopened?

@bodokaiser
Copy link

@robert-hanuschke You find additionalInputs in ShellStepProps.

This is also explained in the additional inputs section:

const prebuild = new ShellStep('Prebuild', {
  input: CodePipelineSource.gitHub('myorg/repo1'),
  primaryOutputDirectory: './build',
  commands: ['./build.sh'],
});

const pipeline = new CodePipeline(this, 'Pipeline', {
  synth: new ShellStep('Synth', {
    input: CodePipelineSource.gitHub('myorg/repo2'),
    additionalInputs: {
      'subdir': CodePipelineSource.gitHub('myorg/repo3'),
      '../siblingdir': prebuild,
    },

    commands: ['./build.sh'],
  })
});

and yes, I agree that such a great feature deserves more visibility.

@robert-hanuschke
Copy link

@bodokaiser ah, so the additional inputs defined in that way also trigger the pipeline (e.g. if nothing changed in myorg/repo1 but in myorg/repo3)? I interpreted that section in the way that the trigger still would only be morg/repo1 but once that fires it additionally loads repo2 and repo3 for supplementary data in support of repo1's changes.

If I thought wrong there and changes to repo2 and repo3 also fire the pipeline - very cool, will try that!

@bodokaiser
Copy link

@robert-hanuschke I think so, in the ShellStep constructor they get the same treatment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/pipelines CDK Pipelines library effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1
Projects
None yet
Development

No branches or pull requests

5 participants