Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-certificatemanager): Imminent end of support for Nodejs 10 Lambda functions #15821

Closed
otterley opened this issue Jul 29, 2021 · 3 comments
Closed
Assignees
Labels
@aws-cdk/aws-certificatemanager Related to Amazon Certificate Manager @aws-cdk/aws-lambda Related to AWS Lambda bug This issue is a bug. effort/medium Medium work item – several days of effort p1

Comments

@otterley
Copy link
Contributor

Support by AWS Lambda for Node.js 10 is ending on August 31, 2021. We should upgrade the Node version in this module to version 14 ASAP after verifying compatibility.

@otterley otterley added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jul 29, 2021
@github-actions github-actions bot added @aws-cdk/aws-certificatemanager Related to Amazon Certificate Manager @aws-cdk/aws-lambda Related to AWS Lambda labels Jul 29, 2021
@otterley otterley changed the title (aws-certificatemanager): Imminent end of support for Lambda support for Nodejs 10 (aws-certificatemanager): Imminent end of support for Nodejs 10 Lambda functions Jul 29, 2021
@ryparker ryparker added effort/medium Medium work item – several days of effort p1 and removed needs-triage This issue or PR still needs to be triaged. labels Jul 29, 2021
@KBB99
Copy link

KBB99 commented Aug 6, 2021

Happy to work on this issue starting Monday.

@njlynch
Copy link
Contributor

njlynch commented Aug 6, 2021

We upgraded all of our custom resources to use NodeJS 14.x as part of #13488, which was released as part of v1.94.0 in March.

const requestorFunction = new lambda.Function(this, 'CertificateRequestorFunction', {
code: lambda.Code.fromAsset(path.resolve(__dirname, '..', 'lambda-packages', 'dns_validated_certificate_handler', 'lib')),
handler: 'index.certificateRequestHandler',
runtime: lambda.Runtime.NODEJS_14_X,
timeout: cdk.Duration.minutes(15),
role: props.customResourceRole,
});

If you're still seeing the version as NodeJS 10, please upgrade to CDK v1.94.0 or above.

I'm going to close this out. Please feel free to comment and @mention me if I've missed something here or if you have any follow-ups.

@njlynch njlynch closed this as completed Aug 6, 2021
@github-actions
Copy link

github-actions bot commented Aug 6, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-certificatemanager Related to Amazon Certificate Manager @aws-cdk/aws-lambda Related to AWS Lambda bug This issue is a bug. effort/medium Medium work item – several days of effort p1
Projects
None yet
Development

No branches or pull requests

5 participants