Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(@aws-cdk/aws-neptune): Amazon CloudWatch Logs Exports properties not available for class DatabaseCluster in Neptune #15888

Closed
2 tasks
haofeif opened this issue Aug 4, 2021 · 8 comments · Fixed by #22004
Closed
2 tasks

(@aws-cdk/aws-neptune): Amazon CloudWatch Logs Exports properties not available for class DatabaseCluster in Neptune #15888

haofeif opened this issue Aug 4, 2021 · 8 comments · Fixed by #22004
Labels
@aws-cdk/aws-cloudwatch Related to Amazon CloudWatch @aws-cdk/aws-logs Related to Amazon CloudWatch Logs @aws-cdk/aws-neptune Related Amazon Neptune effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@haofeif
Copy link

haofeif commented Aug 4, 2021 •
edited
Loading

Use Case

It'll be great to add the properties to be able to enable CloudWatch Logs Export in class DatabaseCluster (construct) :
https://docs.aws.amazon.com/cdk/api/latest/docs/@aws-cdk_aws-neptune.DatabaseCluster.html

Proposed Solution

Be able to set Cloudwatch logs exports with EnableCloudwatchLogsExports prop :

Other

Offered by CFN: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-neptune-dbcluster.html

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@haofeif haofeif added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 4, 2021
@github-actions github-actions bot added @aws-cdk/aws-cloudwatch Related to Amazon CloudWatch @aws-cdk/aws-logs Related to Amazon CloudWatch Logs @aws-cdk/aws-neptune Related Amazon Neptune labels Aug 4, 2021
@rix0rrr
Copy link
Contributor

rix0rrr commented Aug 10, 2021 •
edited
Loading

Edit: I see, the class you linked to is not the class you are requestsing the feature for.

Yes, seems reasonable to add new features to the L2.

@rix0rrr rix0rrr added effort/medium Medium work item – several days of effort p2 and removed needs-triage This issue or PR still needs to be triaged. labels Aug 10, 2021
@rix0rrr rix0rrr removed their assignment Aug 10, 2021
@haofeif
Copy link
Author

haofeif commented Aug 10, 2021

Edit: I see, the class you linked to is not the class you are requestsing the feature for.

Yes, seems reasonable to add new features to the L2.

Sorry for the confusions. Updated the link now.

@rix0rrr rix0rrr removed their assignment Aug 11, 2021
@madeline-k madeline-k removed their assignment Aug 24, 2021
@njlynch njlynch removed their assignment Oct 6, 2021
@swapab
Copy link

swapab commented Jul 28, 2022

Thanks @haofeif for raising this issue. I was also looking for this feature in aws-cdk v2.

I believe the proposed feature would enable Audit Log Export as shown below.
image

Do we know if this feature will be available in v2? or should there be a separate request for that?

@humanzz humanzz mentioned this issue Sep 8, 2022
Closed
2 tasks
@Naumel
Copy link
Contributor

Naumel commented Sep 9, 2022

Duplicate #20248

@humanzz
Copy link
Contributor

humanzz commented Sep 9, 2022

Duplicate #20248

Thanks for ur comment on the other issue. I noticed you closed it, but I want to call out that it also mentions a bit about metrics which I don't believe is covered by this issue

@humanzz
Copy link
Contributor

humanzz commented Sep 11, 2022 •
edited
Loading

@Naumel I've created a PR for the metrics part #21995 related to the other issue. I noticed aws-cdk-owners is the assigned reviewer so am afraid that might get lost since the issue it's related to is closed. Appreciate if u can have a look at this assignment issue!

humanzz added a commit to humanzz/aws-cdk that referenced this issue Sep 12, 2022
@humanzz
feat(neptune): enable cloudwatch logs exports
a7cd6c1 
- introduce LogType and CloudwatchLogsExports for use in DatabaseClusterProps
- introduce cloudwatchLogsExports prop to configure which log types should be exported to CloudWatch Logs and optionally set log retention
- update tests and integ tests
- update README

related to aws#20248
closes aws#15888
@humanzz humanzz mentioned this issue Sep 12, 2022
Merged
4 tasks
@humanzz
Copy link
Contributor

humanzz commented Sep 12, 2022

And here's one for logs #22004

@mergify mergify bot closed this as completed in #22004 Sep 30, 2022
mergify bot pushed a commit that referenced this issue Sep 30, 2022
@humanzz
feat(neptune): enable cloudwatch logs exports (#22004)
2b2bb01 
- introduce LogType and CloudwatchLogsExports for use in DatabaseClusterProps
- introduce cloudwatchLogsExports prop to configure which log types should be exported to CloudWatch Logs and optionally set log retention
- update tests and integ tests
- update README

related to #20248
closes #15888


----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

arewa pushed a commit to arewa/aws-cdk that referenced this issue Oct 8, 2022
@humanzz @arewa
feat(neptune): enable cloudwatch logs exports (aws#22004)
95d04ec 
- introduce LogType and CloudwatchLogsExports for use in DatabaseClusterProps
- introduce cloudwatchLogsExports prop to configure which log types should be exported to CloudWatch Logs and optionally set log retention
- update tests and integ tests
- update README

related to aws#20248
closes aws#15888


----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
homakk pushed a commit to homakk/aws-cdk that referenced this issue Dec 1, 2022
@humanzz @madeline-k
feat(neptune): enable cloudwatch logs exports (aws#22004)
b6fe53f 
- introduce LogType and CloudwatchLogsExports for use in DatabaseClusterProps
- introduce cloudwatchLogsExports prop to configure which log types should be exported to CloudWatch Logs and optionally set log retention
- update tests and integ tests
- update README

related to aws#20248
closes aws#15888


----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-cloudwatch Related to Amazon CloudWatch @aws-cdk/aws-logs Related to Amazon CloudWatch Logs @aws-cdk/aws-neptune Related Amazon Neptune effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(neptune): enable cloudwatch logs exports humanzz/aws-cdk
7 participants
@humanzz @rix0rrr @swapab @njlynch @haofeif @madeline-k @Naumel