Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@aws-cdk/aws-secretsmanager.Secret.import context provider helper #1689

Closed
RomainMuller opened this issue Feb 6, 2019 · 2 comments
Closed

@aws-cdk/aws-secretsmanager.Secret.import context provider helper #1689

RomainMuller opened this issue Feb 6, 2019 · 2 comments
Labels
@aws-cdk/aws-secretsmanager Related to AWS Secrets Manager closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/large Large work item – several weeks of effort feature/enhancement A new API to make things easier or more intuitive. A catch-all for general feature requests. feature-request A feature should be added or improved. p2

Comments

@RomainMuller
Copy link
Contributor

When importing existing secrets, it is highly inconvenient to have to track which EncryptionKey should be used (you have to import the secret AND it's key, otherwise permission grants are not going to be managed for the key).

A context provided could assist in looking up the imported secret's KMS key so one does not have to manually do this.
@RomainMuller RomainMuller added feature-request A feature should be added or improved. @aws-cdk/aws-secretsmanager Related to AWS Secrets Manager labels Feb 6, 2019
@RomainMuller RomainMuller mentioned this issue Feb 6, 2019
Merged
4 tasks
@rix0rrr
Copy link
Contributor

rix0rrr commented Oct 30, 2019

Still relevant

@rix0rrr rix0rrr assigned skinny85 and unassigned rix0rrr Jan 23, 2020
@skinny85 skinny85 added the effort/large Large work item – several weeks of effort label Feb 6, 2020
@SomayaB SomayaB assigned njlynch and unassigned skinny85 Jul 10, 2020
@njlynch njlynch added the p2 label Aug 24, 2020
@njlynch njlynch mentioned this issue Nov 30, 2020
Closed
@ericzbeard ericzbeard added the feature/enhancement A new API to make things easier or more intuitive. A catch-all for general feature requests. label Apr 20, 2021
@njlynch njlynch mentioned this issue Aug 16, 2021
Closed
@github-actions
Copy link

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-secretsmanager Related to AWS Secrets Manager closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/large Large work item – several weeks of effort feature/enhancement A new API to make things easier or more intuitive. A catch-all for general feature requests. feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@RomainMuller @skinny85 @rix0rrr @ericzbeard @njlynch