feat(amplify): Add support for custom headers in the App #17102
Conversation
|
|
|
@skinny85 I made the appropriate changes related to hoisting and |
|
@ayush987goyal I think you're very close. What you need to do is add the following lines to the root "@aws-cdk-alpha/aws-amplify-alpha/yaml",
"@aws-cdk-alpha/aws-amplify-alpha/yaml/**",This needs to be done in addition to the lines you already added there, for |
There was a problem hiding this comment.
Putting in "Request changes" to clear this one from my To-Do list. @ayush987goyal please re-request my review when this is ready!
mergify
bot
dismissed
skinny85’s stale review
Pull request has been modified.
There was a problem hiding this comment.
In general looks good @ayush987goyal, but I'd like some changes to the API and naming before we merge this in 🙂.
mergify
bot
dismissed
skinny85’s stale review
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
feat(amplify): Add support for custom headers in the App closes aws#17084 Refs: 1. https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-amplify-app.html#cfn-amplify-app-customheaders 2. https://docs.aws.amazon.com/amplify/latest/userguide/custom-headers.html 3. https://www.npmjs.com/package/yaml ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
feat(amplify): Add support for custom headers in the App
closes #17084
Refs:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license