Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(synthetics): add syn-nodejs-puppeteer-3.3 runtime #17132

Merged
merged 4 commits into from
Oct 25, 2021

Conversation

msambol
Copy link
Contributor

@msambol msambol commented Oct 24, 2021


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Oct 24, 2021

@github-actions github-actions bot added the @aws-cdk/aws-synthetics Related to Amazon CloudWatch Synthetics label Oct 24, 2021
@msambol
Copy link
Contributor Author

msambol commented Oct 24, 2021

@BenChaimberg How do you regenerate integ.canary.expected.json ? I tried yarn test -u and yarn integ (the latter hangs).

@BenChaimberg
Copy link
Contributor

How do you regenerate integ.canary.expected.json ? I tried yarn test -u and yarn integ (the latter hangs).

You should execute yarn integ to run the integration tests which will deploy the test stacks and update the expected template as necessary. Under the hood, cdk deploy is called so you should debug appropriately. Given that the command is hanging, my immediate thought is that you do not have your AWS credentials configured properly.

Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: a3f6652
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 8343bec into aws:master Oct 25, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@msambol msambol deleted the syn-nodejs-puppeteer-3.3 branch October 26, 2021 03:28
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-synthetics Related to Amazon CloudWatch Synthetics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants