feat(appsync): support custom domain mappings

[moofish32]

fixes #18040

This adds support for custom domains with AppSync.

[gitpod-io]

[msambol]

Can you add a comma or parenthesis after "none" ?

[msambol]

Will this work? You're not initializing it to anything.

[kaizencc]

Will this work? no. Can it compile this way? yes. This is something we are using in our examples for necessary properties that are not essential to the overall example. We don't want to clutter our examples with a new lambda.Function(this, 'myfn', {...}); each time we need one, so it is simpler to write declare const fn: lambda.Function and leave it to the user to provide the exact function they need if they want to use the example.

That being said, I feel like providing a real certificate is necessary to this example, since it is part of the domainName property we are demonstrating. So I do think in this situation we should provide a real certificate.

[moofish32]

So I did not invent this pattern I modeled most of the work from the rest api pattern here

[kaizencc]

Thanks @moofish32 for getting this started! Looks good, with a few minor comments.

[kaizencc]

Will this work? no. Can it compile this way? yes. This is something we are using in our examples for necessary properties that are not essential to the overall example. We don't want to clutter our examples with a new lambda.Function(this, 'myfn', {...}); each time we need one, so it is simpler to write declare const fn: lambda.Function and leave it to the user to provide the exact function they need if they want to use the example.

That being said, I feel like providing a real certificate is necessary to this example, since it is part of the domainName property we are demonstrating. So I do think in this situation we should provide a real certificate.

[kaizencc]

In the docs for domainName you write that "The hosted zone and CName must be configured in addition to this setting to enable custom domain URL" but we do not check for that here.

Are we leaving that requirement as a deploy-time check right now? If so, we probably need to think about how we can make it a synth-time check.

[moofish32]

Again based on how the rest api works today this is a separate action. I felt like we should tell the user to do this, but if we nested this all in this construct I think it would be doing too much. I assume the rest api developers felt the same way, but of course I do not know.

Pull request has been modified.

[kaizencc]

Thanks @moofish32! Added in a few changes (mostly to the readme example, to get it to compile).

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
• Commit ID: 64c1dd7
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[sammy2077]

@moofish32
The code snippet in the README might not work when creating Route53 Record

If you define

const myDomainName = 'api.example.com';

new route53.CnameRecord(this, `CnameApiRecord`, {
  recordName: 'api',
  zone,
  domainName: myDomainName,
});

This is trying to create a DNS record (CNAME) for api.example.com to point to the same address
You need to target the CloudFront URL of the appsync domain.
Like this

new CnameRecord(this, `CnameApiRecord`, {
            recordName: 'api',
            zone,
            domainName: appsyncDomain.attrAppSyncDomainName
        });

See my working sample here #18040 (comment)

[sebastiansanio]

Is it possible to make this work with @aws-cdk/aws-appsync-alpha?