cdk bootstrap can't handle state REVIEW_IN_PROGRESS

[chizou]

What is the problem?

For whatever reason, a previous bootstrap didn't complete. This has left the stack in REVIEW_IN_PROGRESS. Running cdk bootstrap on the region in which the stack is stuck causes cdk to get stuck. When running without any additional options, it just hangs. It requires you to run with --verbose --debug to start getting some output that tells you what's going on.

Reproduction Steps

Create a bootstrap stack and leave it in a REVIEW_IN_PROGRESS state. Then try to run cdk bootstrap

What did you expect to happen?

It should give me an option to execute the change set. I would have thought since --execute is default, it would have just executed the change sets. It also shouldn't just hang. It should at least give me an error or something letting me know it's waiting. It also probably should have some kind of timeout implemented

What actually happened?

It just hangs

CDK CLI Version

2.15.0 (build 151055e)

Framework Version

No response

Node.js Version

v16.14.0

OS

WSL2

Language

Python

Language Version

Python 3.7.13

Other information

No response

[rix0rrr]

The initial wait for stabilization should print that it's waiting, and give up if the stack doesn't stabilize in X time. It could also say something like Do you want to continue waiting (Y/n)?

[chizou]

@rix0rrr that may be true, but I'm running the job in a Jenkins pipeline and Jenkins might be swallowing the output. Is there a way to always reject waiting via a cli flag?

[rix0rrr]

I see. It looks like we can treat REVIEW_IN_PROGRESS the same as ROLLBACK_COMPLETE: a stack failed to create initially, and the solution is to delete it and recreate.

The change probably needs to be made here:

aws-cdk/packages/aws-cdk/lib/api/util/cloudformation/stack-status.ts

Lines 15 to 18 in 4f12209

	get isCreationFailure(): boolean {
	return this.name === 'ROLLBACK_COMPLETE'
	|| this.name === 'ROLLBACK_FAILED';
	}

I don't have time to change and test this myself, but contributions are welcome.

[simonespa]

I had the same problem just now and I too had to use -v to see what was going on.

[scanlonp]

This was addressed in #23230.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.