feat(integ-tests): Add `IntegTestCase` #19829

otaviomacedo · 2022-04-08T14:05:40Z

Adds a new construct, IntegTestCase, to allow integration test authors to define tests with which they can control the test execution workflow. In future iterations, it will also allow authors to register live infrastructure assertions.

All Submissions:

Have you followed the guidelines in our Contributing guide?

Adding new Unconventional Dependencies:

This PR adds new unconventional dependencies following the process described here

New Features

Have you added the new feature to an integration test?
- Did you use cdk-integ to deploy the infrastructure and generate the snapshot (i.e. cdk-integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

gitpod-io · 2022-04-08T14:05:47Z

packages/@aws-cdk/integ-tests/lib/test-case.ts

…act (#19778) When using helm to pull OCI artifacts, the helm pull command doesn't works well. The [check_output](https://stackoverflow.com/questions/3172470/actual-meaning-of-shell-true-in-subprocess) uses shell=True. That means that all arguments of the commands being passed to the check_output are basically been passed to the shell and not to the helm pull command. Using shell is also discouraged from [security perspective](https://docs.python.org/3/library/subprocess.html#security-considerations) References: https://docs.python.org/3/library/subprocess.html > On POSIX with shell=True, the shell defaults to /bin/sh. If args is a string, the string specifies the command to execute through the shell. This means that the string must be formatted exactly as it would be when typed at the shell prompt. This includes, for example, quoting or backslash escaping filenames with spaces in them. If args is a sequence, the first item specifies the command string, and any additional items will be treated as additional arguments to the shell itself. https://stackoverflow.com/questions/3172470/actual-meaning-of-shell-true-in-subprocess The previous change that used the `Shell=True` was introduced in commit - #18547 (comment) EDIT: Adding commit for the following items: - Adding integration test for helm OCI support in aws-eks - Upgrading helm version to 3.8.1 in `aws-lambda-layer` because of issues with the current version of helm that is been used, for OCI chart supports - update `integ.eks-helm-asset.expected.json` file ---- ### All Submissions: * [X] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) - NO new unconventional dependencies ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? - NO * [ ] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)? - NO *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

This should have been a part of #19773. Ensures that old imports of `@aws-cdk/core/lib/cfn-parse` still work, so that it is not a breaking change. ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [ ] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

- Modified to allow selection of sslSupportMethod closes #19476 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [ ] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

@kaizen3031593

Prerequisite for Lambda URL feature #19798 cc @kaizen3031593 @ayush987goyal ``` # CloudFormation Resource Specification v66.0.0 ## New Resource Types * AWS::DataSync::LocationFSxOpenZFS * AWS::Events::Endpoint * AWS::Lambda::Url * AWS::MediaTailor::PlaybackConfiguration ## Attribute Changes ## Property Changes * AWS::Batch::ComputeEnvironment ReplaceComputeEnvironment (__added__) * AWS::Batch::ComputeEnvironment UpdatePolicy (__added__) * AWS::EC2::TrafficMirrorTarget GatewayLoadBalancerEndpointId (__added__) * AWS::Lambda::Permission FunctionUrlAuthType (__added__) ## Property Type Changes * AWS::Batch::ComputeEnvironment.UpdatePolicy (__added__) * AWS::EC2::LaunchTemplate.MaintenanceOptions (__added__) * AWS::Batch::ComputeEnvironment.ComputeResources UpdateToLatestImageVersion (__added__) * AWS::Batch::ComputeEnvironment.ComputeResources AllocationStrategy.UpdateType (__changed__) * Old: Immutable * New: Mutable * AWS::Batch::ComputeEnvironment.ComputeResources BidPercentage.UpdateType (__changed__) * Old: Immutable * New: Mutable * AWS::Batch::ComputeEnvironment.ComputeResources Ec2Configuration.UpdateType (__changed__) * Old: Immutable * New: Mutable * AWS::Batch::ComputeEnvironment.ComputeResources Ec2KeyPair.UpdateType (__changed__) * Old: Immutable * New: Mutable * AWS::Batch::ComputeEnvironment.ComputeResources ImageId.UpdateType (__changed__) * Old: Immutable * New: Mutable * AWS::Batch::ComputeEnvironment.ComputeResources InstanceRole.UpdateType (__changed__) * Old: Immutable * New: Mutable * AWS::Batch::ComputeEnvironment.ComputeResources InstanceTypes.UpdateType (__changed__) * Old: Immutable * New: Mutable * AWS::Batch::ComputeEnvironment.ComputeResources LaunchTemplate.UpdateType (__changed__) * Old: Immutable * New: Mutable * AWS::Batch::ComputeEnvironment.ComputeResources PlacementGroup.UpdateType (__changed__) * Old: Immutable * New: Mutable * AWS::Batch::ComputeEnvironment.ComputeResources Tags.UpdateType (__changed__) * Old: Immutable * New: Mutable * AWS::Batch::ComputeEnvironment.ComputeResources Type.UpdateType (__changed__) * Old: Immutable * New: Mutable * AWS::Batch::ComputeEnvironment.Ec2ConfigurationObject ImageIdOverride.UpdateType (__changed__) * Old: Immutable * New: Mutable * AWS::Batch::ComputeEnvironment.Ec2ConfigurationObject ImageType.UpdateType (__changed__) * Old: Immutable * New: Mutable * AWS::Batch::ComputeEnvironment.LaunchTemplateSpecification LaunchTemplateId.UpdateType (__changed__) * Old: Immutable * New: Mutable * AWS::Batch::ComputeEnvironment.LaunchTemplateSpecification LaunchTemplateName.UpdateType (__changed__) * Old: Immutable * New: Mutable * AWS::Batch::ComputeEnvironment.LaunchTemplateSpecification Version.UpdateType (__changed__) * Old: Immutable * New: Mutable * AWS::DMS::Endpoint.DocDbSettings DocsToInvestigate (__added__) * AWS::DMS::Endpoint.DocDbSettings ExtractDocId (__added__) * AWS::DMS::Endpoint.DocDbSettings NestingLevel (__added__) * AWS::DMS::Endpoint.IbmDb2Settings CurrentLsn (__added__) * AWS::DMS::Endpoint.IbmDb2Settings MaxKBytesPerRead (__added__) * AWS::DMS::Endpoint.IbmDb2Settings SetDataCaptureChanges (__added__) * AWS::DMS::Endpoint.MicrosoftSqlServerSettings BcpPacketSize (__added__) * AWS::DMS::Endpoint.MicrosoftSqlServerSettings ControlTablesFileGroup (__added__) * AWS::DMS::Endpoint.MicrosoftSqlServerSettings QuerySingleAlwaysOnNode (__added__) * AWS::DMS::Endpoint.MicrosoftSqlServerSettings ReadBackupOnly (__added__) * AWS::DMS::Endpoint.MicrosoftSqlServerSettings SafeguardPolicy (__added__) * AWS::DMS::Endpoint.MicrosoftSqlServerSettings UseBcpFullLoad (__added__) * AWS::DMS::Endpoint.MicrosoftSqlServerSettings UseThirdPartyBackupDevice (__added__) * AWS::DMS::Endpoint.RedshiftSettings AcceptAnyDate (__added__) * AWS::DMS::Endpoint.RedshiftSettings AfterConnectScript (__added__) * AWS::DMS::Endpoint.RedshiftSettings BucketFolder (__added__) * AWS::DMS::Endpoint.RedshiftSettings BucketName (__added__) * AWS::DMS::Endpoint.RedshiftSettings CaseSensitiveNames (__added__) * AWS::DMS::Endpoint.RedshiftSettings CompUpdate (__added__) * AWS::DMS::Endpoint.RedshiftSettings ConnectionTimeout (__added__) * AWS::DMS::Endpoint.RedshiftSettings DateFormat (__added__) * AWS::DMS::Endpoint.RedshiftSettings EmptyAsNull (__added__) * AWS::DMS::Endpoint.RedshiftSettings EncryptionMode (__added__) * AWS::DMS::Endpoint.RedshiftSettings ExplicitIds (__added__) * AWS::DMS::Endpoint.RedshiftSettings FileTransferUploadStreams (__added__) * AWS::DMS::Endpoint.RedshiftSettings LoadTimeout (__added__) * AWS::DMS::Endpoint.RedshiftSettings MaxFileSize (__added__) * AWS::DMS::Endpoint.RedshiftSettings RemoveQuotes (__added__) * AWS::DMS::Endpoint.RedshiftSettings ReplaceChars (__added__) * AWS::DMS::Endpoint.RedshiftSettings ReplaceInvalidChars (__added__) * AWS::DMS::Endpoint.RedshiftSettings ServerSideEncryptionKmsKeyId (__added__) * AWS::DMS::Endpoint.RedshiftSettings ServiceAccessRoleArn (__added__) * AWS::DMS::Endpoint.RedshiftSettings TimeFormat (__added__) * AWS::DMS::Endpoint.RedshiftSettings TrimBlanks (__added__) * AWS::DMS::Endpoint.RedshiftSettings TruncateColumns (__added__) * AWS::DMS::Endpoint.RedshiftSettings WriteBufferSize (__added__) * AWS::EC2::LaunchTemplate.LaunchTemplateData MaintenanceOptions (__added__) ``` ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [ ] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

this is bigger than a typo but smaller than a feature changed: ``` This is a blank project for <LANG> development with CDK. ``` to: ``` This is a blank project for CDK development with <LANG>. ``` ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

The bulk of this PR is adding the new style integration test snapshots that the new `integ-runner` uses. These are snapshots of the cloud assembly and have folder names like `${testName}.integ.snapshot`. Some other minor updates were made as part of this change. 1. Updated `integ-runner` to use `synthFast` instead of `synth` to speed up performance. 2. Make sure the `integ-runner` throws an exit code if any tests fail 3. Updated the test names to include the directory if running from a parent directory (i.e. `packages/@aws-cdk`). 4. Added the ability to exempt from the update workflow (update workflow is not yet implemented). If a test is exempt then the snapshot will not contain any assets. For now this is used for tests that include very large assets that would drastically increase the size of the repo. 5. Updated some custom resources to exclude `*.ts` files from the asset bundle. `.ts` files are already excluded when we publish (`.d.ts` files are not), and `.js` files are the only thing needed by the Lambda function anyway. This was causing issues when running a build because those files in the snapshot would cause `tsc` to fail. - Updated: `aws-events-targets/lib/aws-api.ts` `aws-redshift/lib/private/database-query.ts` `aws-stepfunctions-tasks/lib/evaluate-expression.ts` `custom-resources/lib/aws-custom-resource/aws-custom-resource.ts` `custom-resources/lib/provider-framework/provider.ts` ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [x] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Number attributes go through two levels of encoding: - L1: because of lack of type information, all attributes are assumed to be `string`s, so we do `Token.asString(new CfnReference(...))`. - L2: we recast select attributes to numbers by doing `Token.asNumber()`. The end result is a Token that looks like: ```ts asNumber(Intrinsic(asString(CfnReference({ 'Fn::GetAtt': [...] })))) ``` When we do `Tokenization.reverse()` on the number, we only reverse the *first* encoding one layer, leaving us with an `Intrinsic` instead of the original `CfnReference`. `exportValue()` then rejects the value as not being the right type of token. Solution: before encoding, try to decode the given value so we always encode the innermost token, and not any of the inbetween ones. Fixes #19537. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Warning message grammar correction ---- ### All Submissions: * [X] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [ ] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Closes #19803 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [ ] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

### Summary This patch fixes the following bugs in `maxInstanceLifetime` validation by aligning with [CFN doc](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-as-group.html#cfn-as-group-maxinstancelifetime): - A lower bound of `maxInstanceLifetime` is 1 day, not 7-days. - `maxInstanceLifetime` can have 0 which is used to clear a previously set value. ### Test - Run unit test. ``` PASS test/auto-scaling-group.test.js =============================== Coverage summary =============================== Statements : 93.11% ( 419/450 ) Branches : 86.93% ( 286/329 ) Functions : 91.81% ( 101/110 ) Lines : 92.84% ( 402/433 ) ================================================================================ ``` - Deploy CFN template having `maxInstanceLifetime` as 86,400 and 0. ### Notes Originally, this issue was reported by #12588. ---- ### All Submissions: * [X] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [ ] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Small changes to make builds work in Windows Subsystem for Linux (WSL). Verified by **partial** building in Windows 10 + Ubuntu 18.04 WSL. fixes #55 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

This PR is a follow up to #19802 which added all of the new integ test snapshots that are used by the new `integ-runner` tool. This PR switches out the old `cdk-integ` tool for the new `integ-runner`. Updates made: 1. Update all `package.json` files to install and use the `integ-runner` 2. Update `cdk-test` to use `integ-runner` 3. Updates snapshots for 2 tests that were changed since #19802 was merged. ---- ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [ ] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

This PR includes to implement comparison operators. - [x] integ test ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

In the newest version of the MySQL 8.0 Aurora engine, the S3 import and export Roles need to be combined, which is the first time this is needed for a Cluster (previously, only Instances combined these two Roles). Introduce this concept as a first-class property of a Cluster Engine, making it `false` by default, and make it `true` in MySQL version 8.0. Fixes #19735 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [x] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

fixes #19626 added integ tests let me know if change to readme is necessary ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [x] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Some services still use the deprecated `trustedSigners` property, which is preventing teams which depend on those services from upgrading to V2. This change adds `trustedSigners` back into V2, but leaves it marked as `@deprecated`. Closes #19837 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Ran npm-check-updates and yarn upgrade to keep the `yarn.lock` file up-to-date.

Introduces the following changes to secrets handling: - Deprecate `SecretValue.plainText()` in favor of `SecretValue.unsafePlainText()` to highlight its issues - Introduce `SecretValue.resourceAttribute()` for cases where we know we want to use a value produced at deployment time - Introduce a new feature flag (`@aws-cdk/core:checkSecretUsage`) which, when enabled, will make it impossible to use secrets without explicitly unwrapping them first (`secretValue.unsafeUnwrap`). This prevents people from naively sticking secrets into vulnerable locations like environment variables. - Deprecate `secretsmanager.SecretStringValueBeta1` in favor of just accepting a `SecretValue`. Since this behavior would constitute a breaking change, it will only be enabled if the feature flag `@aws-cdk/core:checkSecretUsage` is turned on. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Bumps [hmarr/auto-approve-action](https://github.com/hmarr/auto-approve-action) from 2.2.0 to 2.2.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/hmarr/auto-approve-action/releases">hmarr/auto-approve-action's releases</a>.</em></p> <blockquote> <h2>v2.2.1</h2> <ul> <li>Switch back to using Node 12, as the Node 16 upgrade in v2.2.0 caused issues for people using self-hosted runners with GHES versions prior to 3.4</li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/hmarr/auto-approve-action/compare/v2.2.0...v2.2.1">https://github.com/hmarr/auto-approve-action/compare/v2.2.0...v2.2.1</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/hmarr/auto-approve-action/commit/24ec4c8cc344fe1cdde70ff37e55ace9e848a1d8"><code>24ec4c8</code></a> Switch back to node 12</li> <li><a href="https://github.com/hmarr/auto-approve-action/commit/a4d339b7894ac76f7ae8c668cf4ec268052a6256"><code>a4d339b</code></a> Update documentation</li> <li>See full diff in <a href="https://github.com/hmarr/auto-approve-action/compare/v2.2.0...v2.2.1">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=hmarr/auto-approve-action&package-manager=github_actions&previous-version=2.2.0&new-version=2.2.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>

Implementation of one of the solutions I proposed in #19797 using glob-style expressions to match keys. Uses minimatch which already existed as a dependency to match stack names in the synth and deploy commands. Makes the --reset command throw on no-ops i.e when trying to reset context defined in cdk.json or ~/.cdk.json Adds tests and prints messages to clarify previously undocumented behavior. ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

corymhall · 2022-04-11T16:11:28Z

packages/@aws-cdk/integ-tests/THIRD_PARTY_LICENSES

@@ -0,0 +1,902 @@
+The @aws-cdk/integ-runner package includes the following third-party software/licensing:


I don't think this file is needed. I think it is only needed if you are bundling a CLI.

mergify · 2022-04-12T18:39:10Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2022-04-12T19:23:31Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
Commit ID: 8db678f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2022-04-12T19:23:51Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Adds a new construct, `IntegTestCase`, to allow integration test authors to define tests with which they can control the test execution workflow. In future iterations, it will also allow authors to register live infrastructure assertions. ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [ ] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

otaviomacedo added 3 commits April 7, 2022 15:37

chore(integ-runner): add a manifest writer

32f2a3f

Moved writer to a new package

b915908

feat(integ-tests): added IntegTestCase construct

86ea9dd

github-actions bot added the p2 label Apr 8, 2022

aws-cdk-automation requested a review from a team April 8, 2022 14:05

mergify bot added the contribution/core This is a PR that came from AWS. label Apr 8, 2022

otaviomacedo changed the title ~~chore(integ-runner): add a manifest writer~~ feat(integ-tests): Add IntegTestCase Apr 8, 2022

corymhall reviewed Apr 8, 2022

View reviewed changes

packages/@aws-cdk/integ-tests/lib/test-case.ts Outdated Show resolved Hide resolved

packages/@aws-cdk/integ-tests/lib/test-case.ts Outdated Show resolved Hide resolved

otaviomacedo and others added 21 commits April 11, 2022 09:17

Simplified snapshot dir logic and removed the stack

b2e0a80

Added README

e769393

chore(release): 1.152.0

1aec060

docs(cfnspec): update CloudFormation documentation (#19819)

bdcadfc

feat(iotevents): support comparison operators (#19329)

7bca49f

This PR includes to implement comparison operators. - [x] integ test ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

chore: npm-check-updates && yarn upgrade (#19788)

10fe28f

Ran npm-check-updates and yarn upgrade to keep the `yarn.lock` file up-to-date.

rix0rrr and others added 7 commits April 11, 2022 14:29

docs(cfnspec): update CloudFormation documentation (#19854)

b0109b2

Added tsconfig.json

e7846c6

Added jsii config

1e204ab

otaviomacedo changed the base branch from otaviom/integ-manifest-writer to master April 11, 2022 14:14

otaviomacedo added 3 commits April 11, 2022 15:26

Merge branch 'master' into otaviom/integ-test-case-construct

09cf3c1

Merge branch 'master' into otaviom/integ-test-case-construct

77928e6

Fixed README

eaad71b

otaviomacedo marked this pull request as ready for review April 11, 2022 16:00

Added newline at the end of README

ec0177d

otaviomacedo requested a review from corymhall April 12, 2022 08:14

otaviomacedo added 5 commits April 12, 2022 10:04

Added integ-tests to aws-cdk-lib's dependencies

e85a27a

Added @aws-cdk/integ-tests to monocdk's dependencies

2e2aa6e

Make the README snippets compile

2210580

Changed the API to have stacks instead of ids

9b1c83f

Added documentation

6baf6ab

corymhall approved these changes Apr 12, 2022

View reviewed changes

corymhall added the pr/do-not-merge This PR should not be merged at this time. label Apr 12, 2022

Removed THIRD_PARTY_LICENSES

fb4f15d

corymhall removed the pr/do-not-merge This PR should not be merged at this time. label Apr 12, 2022

Merge branch 'master' into otaviom/integ-test-case-construct

8db678f

mergify bot merged commit ad249c9 into master Apr 12, 2022

mergify bot deleted the otaviom/integ-test-case-construct branch April 12, 2022 19:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(integ-tests): Add `IntegTestCase` #19829

feat(integ-tests): Add `IntegTestCase` #19829

otaviomacedo commented Apr 8, 2022 •

edited

Loading

gitpod-io bot commented Apr 8, 2022

corymhall Apr 11, 2022

otaviomacedo Apr 12, 2022

mergify bot commented Apr 12, 2022

aws-cdk-automation commented Apr 12, 2022

mergify bot commented Apr 12, 2022

		@@ -0,0 +1,902 @@
		The @aws-cdk/integ-runner package includes the following third-party software/licensing:

feat(integ-tests): Add IntegTestCase #19829

feat(integ-tests): Add IntegTestCase #19829

Conversation

otaviomacedo commented Apr 8, 2022 • edited Loading

All Submissions:

Adding new Unconventional Dependencies:

New Features

gitpod-io bot commented Apr 8, 2022

corymhall Apr 11, 2022

Choose a reason for hiding this comment

otaviomacedo Apr 12, 2022

Choose a reason for hiding this comment

mergify bot commented Apr 12, 2022

aws-cdk-automation commented Apr 12, 2022

AWS CodeBuild CI Report

mergify bot commented Apr 12, 2022

feat(integ-tests): Add `IntegTestCase` #19829

feat(integ-tests): Add `IntegTestCase` #19829

otaviomacedo commented Apr 8, 2022 •

edited

Loading