Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(cognito): Support for all SES regions #21245

Closed
1 of 2 tasks
ludimax opened this issue Jul 20, 2022 · 2 comments · Fixed by #21557
Closed
1 of 2 tasks

(cognito): Support for all SES regions #21245

ludimax opened this issue Jul 20, 2022 · 2 comments · Fixed by #21557
Assignees
@peterwoodworth
Labels
@aws-cdk/aws-cognito Related to Amazon Cognito documentation This is a problem with documentation. effort/small Small work item – less than a day of effort p1

Comments

@ludimax
Copy link

ludimax commented Jul 20, 2022

Describe the feature

Currently sesRegion property only support regions 'us-east-1', 'us-west-2', or 'eu-west-1'. See also documentation https://docs.aws.amazon.com/cdk/api/v1/docs/@aws-cdk_aws-cognito.UserPoolSESOptions.html. It should be possible to use all available Cognito SES regions. Via the console this is already possible.

Use Case

Enable SES in Cognito in other regions as well (for example eu-central-1)

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

1.165.0

Environment details (OS name and version, etc.)

n/a
@ludimax ludimax added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 20, 2022
@github-actions github-actions bot added the @aws-cdk/aws-cognito Related to Amazon Cognito label Jul 20, 2022
@peterwoodworth
Copy link
Contributor

We don't have any checks to ensure you're typing in a valid region. I think you should be able to deploy this successfully now if you ignore the documentation

@peterwoodworth peterwoodworth added p1 effort/small Small work item – less than a day of effort documentation This is a problem with documentation. and removed feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 29, 2022
watany-dev added a commit to watany-dev/aws-cdk that referenced this issue Aug 11, 2022
@watany-dev
aws#21245 Indicate in the documentation that there are no region rest…
a2d0b7e 
…rictions.
@watany-dev watany-dev mentioned this issue Aug 11, 2022
Merged
4 tasks
@mergify mergify bot closed this as completed in #21557 Aug 11, 2022
mergify bot pushed a commit that referenced this issue Aug 11, 2022
@watany-dev
doc(cognito): Indicates no region restrictions (#21557)
c81068b 
fixed: #21245  

Remove the statement that it can only be handled in a specific region. Like other services, we will not add a list of regions used.

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

josephedward pushed a commit to josephedward/aws-cdk that referenced this issue Aug 30, 2022
@watany-dev @josephedward
doc(cognito): Indicates no region restrictions (aws#21557)
74f5489 
fixed: aws#21245  

Remove the statement that it can only be handled in a specific region. Like other services, we will not add a list of regions used.

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterwoodworth peterwoodworth

Labels
@aws-cdk/aws-cognito Related to Amazon Cognito documentation This is a problem with documentation. effort/small Small work item – less than a day of effort p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc(cognito): Indicates no region restrictions watany-dev/aws-cdk
3 participants
@ludimax @corymhall @peterwoodworth