[apigateway]: Configured responseHeaders in apigateway.GatewayResponse doesn't support mapping

[grmorozov]

Describe the bug

GatewayResponse parameter mapping is broken after adding forced quotation of all parameters in this PR.

Previously, request parameters could be mapped to response parameters, for example headers.
That's it method.request.header.<name> should be a valid value for a response parameter. With forced quotation around parameter values, method.request.header.<name> becomes a string value and doesn't work.

Expected Behavior

CDK should not add extra quotes for GatewayResponse parameters. It should be possible to use request parameter values in response headers.

Current Behavior

CDK forces quotes around GatewayResponse parameter values. Mapping of request parameters in the response doesn't work.

Reproduction Steps

import * as apigateway from "aws-cdk-lib/aws-apigateway";
...
const api = new apigateway.RestApi(...);

api.addGatewayResponse(`gatewayResponse`, {
      type: apigateway.ResponseType.ACCESS_DENIED,
      responseHeaders: {
        'Access-Control-Allow-Origin': 'method.request.header.origin',
        'Access-Control-Allow-Credentials': "'true'",
        'Access-Control-Expose-Headers': "'x-amzn-errortype'",
      },
    })

Possible Solution

Reverting changes from this PR should solve the issue.

Additional Information/Context

No response

CDK CLI Version

2.48.0

Framework Version

No response

Node.js Version

v16.18.0

OS

macOS Monteray

Language

Typescript

Language Version

No response

Other information

The documentation about API Gateway responses doesn't clearly describe the use case of using request parameters in the response. More clear statement with an example can be found in OpenAPI documentation.

[yuyokk]

Changes were reverted #23037

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

[grmorozov]

23037 was merged 6 days ago. However with the latest version (2.52.0) I can still reproduce the issue.

[peterwoodworth]

The revert PR wasn't part of our 2.52.0 release, only one change made it through. The next version we release I would expect to have all the changes made since 2.51.0 launched. Feel free to ping me or reopen this if the bug is still present next release

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

[frikille]

@peterwoodworth Seems like with the latest release (v2.53.0) this is still not fixed: https://github.com/aws/aws-cdk/blob/v2.53.0/packages/@aws-cdk/aws-apigateway/lib/gateway-response.ts

[peterwoodworth]

Yes, this release was also a special case where we only merged one specific fix. Our next standard release I should say... I would expect next week