Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-ecs-patterns (QueueProcessingFargateService): Make Target CPU Utilization configurable #23624

Closed
1 of 2 tasks
VarshaVid opened this issue Jan 10, 2023 · 3 comments
Closed
1 of 2 tasks
Labels
@aws-cdk/aws-ecs-patterns Related to ecs-patterns library effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@VarshaVid
Copy link
Contributor

VarshaVid commented Jan 10, 2023

Describe the feature

The current scaling policy defined in QueueProcessingServiceBase sets the targetUtilizationPercent at 50%, and is not configurable.

protected configureAutoscalingForService(service: BaseService) {

This value should be configurable by users.

Use Case

We have an application that works on a high throughput queue, but the processing is not latency-sensitive and we can afford to run hotter on the CPU, allowing us to run fewer ECS tasks and save on cost.

Proposed Solution

This value should be configurable through an optional parameter added to QueueProcessingServiceBaseProps (and , by extension, QueueProcessingFargateServiceProps). If not specified by the user, this will default to 50% utilization, for backward compatibility.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

1.141

Environment details (OS name and version, etc.)

NodeJS-14

@VarshaVid VarshaVid added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 10, 2023
@github-actions github-actions bot added the @aws-cdk/aws-ecs-patterns Related to ecs-patterns library label Jan 10, 2023
@peterwoodworth peterwoodworth added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jan 10, 2023
@peterwoodworth
Copy link
Contributor

Our L3 constructs will make some opinionated choices like this, this is something we could add but typically if you need fine-grained control then building patterns with your own L2 constructs is a better choice if the modifications you need to make aren't easily achievable with escape hatches

@AnuragMohapatra
Copy link
Contributor

This issue should be closed after the merge of PR #28315 which introduces a prop to change the target CPU utilization on the main construct instead of base props.

Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ecs-patterns Related to ecs-patterns library effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

4 participants