Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime info broken in NodeJS 12.0.0+ #2530

Closed
SanderKnape opened this issue May 12, 2019 · 2 comments
Closed

Runtime info broken in NodeJS 12.0.0+ #2530

SanderKnape opened this issue May 12, 2019 · 2 comments
Labels
bug This issue is a bug. closing-soon This issue will automatically close in 4 days unless further comments are made.

Comments

@SanderKnape
Copy link

Describe the bug
When running NodeJS 12.0.0 or higher (tested with 12.0.0 and 12.1.0), the runtime information does not contain the versions for the private NodeJS libraries anymore. The require.resolve function used here doesn't properly return the package module.

I believe this is a breaking change introduced in NodeJS 12.0.0 through this PR: nodejs/node#23683

Maybe for now it's an option to add a NodeJS version constraint to the package.json file with a < 12.0.0.

To Reproduce

  • Install NodeJS 12.0.0 or higher (e.g. through nodenv)
  • Run the tests for the CDK app
cd /path/to/aws-cdk/packages/@aws-cdk/cdk
../../../node_modules/.bin/nodeunit test/test.app.js
  • Note how the runtime library versions and version reporting includes only @aws-cdk, aws-cdk and jsii libraries tests fail

Expected behavior
Non-failing tests

Version:

  • OS: OSX
  • Programming Language: NodeJS 12.0.0 +
  • CDK Version: 0.31.0
@SanderKnape SanderKnape added the bug This issue is a bug. label May 12, 2019
@RomainMuller
Copy link
Contributor

@SanderKnape I reckon I have fixed this. Can you confirm the behavior is correct with the latest CDK?

@RomainMuller RomainMuller added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Jun 26, 2019
@SanderKnape
Copy link
Author

Double checked, works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. closing-soon This issue will automatically close in 4 days unless further comments are made.
Projects
None yet
Development

No branches or pull requests

2 participants