-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(scheduler): ScheduleTargetInput #25663
feat(scheduler): ScheduleTargetInput #25663
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
* Pass text to the target, it is possible to embed `ContextAttributes` and other | ||
* cdk references. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we specify what is cdk references?
packages/@aws-cdk/aws-scheduler-alpha/test/schedule-expression.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, but I dont really have a problem with most of this
packages/@aws-cdk/aws-scheduler-alpha/test/schedule-expression.test.ts
Outdated
Show resolved
Hide resolved
About This is from the AutoScaling module: /**
* Construct a Schedule from a moment in time
*/
public static at(moment: Date): Schedule {
return new LiteralSchedule(`at(${formatISO(moment)})`);
} It implicitly converts the date passed in to UTC with the local timeZone (local to cdk). Probably also not very intuitive. How about the following: public static at(localYear: number, localMonth: number, localDay: number, localHour: number, localMinute: number, localSeconds: int, timeZone?: TimeZone): ScheduleExpression {
...
} |
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's still a few open comments to be addressed before this gets approved. I'll take another look next week.
packages/@aws-cdk/aws-scheduler-alpha/test/schedule-expression.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Filipp Fediakov <fediakovphilip@gmail.com>
Co-authored-by: Filipp Fediakov <fediakovphilip@gmail.com>
Co-authored-by: Filipp Fediakov <fediakovphilip@gmail.com>
Co-authored-by: Kaizen Conroy <36202692+kaizencc@users.noreply.github.com>
comment changed
…co/aws-cdk into feat(scheduler)--ScheduleTargetInput
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This PR contains implementation of ScheduleTargetInput. While a schedule is the main resource in Amazon EventBridge Scheduler, this PR adds ScheduleTargetInput on which ScheduleTargetBase depends.
Every Schedule has a target that determines what extra information is sent to the target when the schedule is triggered. Also 4 ContextAttributes can be used that will be resolved at trigger-time.
To be able to create sensible unit tests, also the a start is made to add the
Schedule
and theLambdaInvoke
target as described in the RFC.Implementation is based on RFC: https://github.com/aws/aws-cdk-rfcs/blob/master/text/0474-event-bridge-scheduler-l2.md
Also added a small fix to 2 of the unit tests of the previous PR for this module.
Advances #23394
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license