Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(integ-tests): Allow to specify qualifier #25874

Closed
1 of 2 tasks
kornicameister opened this issue Jun 6, 2023 · 3 comments
Closed
1 of 2 tasks

(integ-tests): Allow to specify qualifier #25874

kornicameister opened this issue Jun 6, 2023 · 3 comments
Labels
@aws-cdk/integ-tests feature-request A feature should be added or improved. p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.

Comments

@kornicameister
Copy link
Contributor

Describe the feature

Ability to specify qualifier when deploying integ-tests.IntegTest.

Use Case

In my environment I am using custom qualifier for my stacks.
I made an attempt to use integ-tests module to see if it can be used to boost up the quality of stacks however I have noticed that

new IntegTest(APP, 'integ-stack', {
  testCases: [productionStack, testingStack],
});

defaults to hnb659fds which is the default qualifier.

Proposed Solution

Allow to pass qualifier as prop into IntegTest

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.81.1

Environment details (OS name and version, etc.)

MacOs

@kornicameister kornicameister added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jun 6, 2023
@peterwoodworth
Copy link
Contributor

Are you specifying the qualifier on your stacks? See this other thread, the qualifier seems to be working for this user #25821

@peterwoodworth peterwoodworth added p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. and removed needs-triage This issue or PR still needs to be triaged. labels Jun 6, 2023
@kornicameister
Copy link
Contributor Author

I think it had helped, thx.

@github-actions
Copy link

github-actions bot commented Jun 6, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/integ-tests feature-request A feature should be added or improved. p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.
Projects
None yet
Development

No branches or pull requests

2 participants