Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-rds: add support for adding secrets to an RDS Proxy #26780

Open
2 tasks
mneirynck opened this issue Aug 16, 2023 · 1 comment
Open
2 tasks

aws-rds: add support for adding secrets to an RDS Proxy #26780

mneirynck opened this issue Aug 16, 2023 · 1 comment
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p3

Comments

@mneirynck
Copy link

Describe the feature

I would like to be able to add secrets to an RDS Proxy after the proxy has been created in an easy to use way.

Use Case

We have an RDS stack and have multiple Application stacks that use SSM exported parameters from the RDS Stack.
The RDS Proxy is created in the RDS stack before any application stack exists, so only one secret is known to the proxy at creation time (the one for the proxy itself).

When we create an application stack we would like to get that RDS Proxy and call a addSecret method on it to add the RDS Secret that is created for the application user.

Proposed Solution

The DatabaseProxy could add a method addSecret(ISecret) that adds the secret to the proxy and grants read access from the proxy to the secret.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.91.0

Environment details (OS name and version, etc.)

Linux

@mneirynck mneirynck added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 16, 2023
@github-actions github-actions bot added the @aws-cdk/aws-rds Related to Amazon Relational Database label Aug 16, 2023
@peterwoodworth
Copy link
Contributor

This should be possible if we calculate this lazily

auth: props.secrets.map(_ => {

However this could potentially be a breaking change if people are using escape hatches here, since producing lazy values messes with escape hatches. Could still be something we support, thanks for the request

@peterwoodworth peterwoodworth added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Aug 16, 2023
@pahud pahud added p3 and removed p2 labels Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p3
Projects
None yet
Development

No branches or pull requests

3 participants