Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-rds): addRotationSingleUser() creates a lambda on python 3.7 which is EOL #26866

Closed
wilhen01 opened this issue Aug 24, 2023 · 4 comments · Fixed by #26884
Closed

(aws-rds): addRotationSingleUser() creates a lambda on python 3.7 which is EOL #26866

wilhen01 opened this issue Aug 24, 2023 · 4 comments · Fixed by #26884
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database bug This issue is a bug. effort/small Small work item – less than a day of effort p2

Comments

@wilhen01
Copy link
Contributor

Describe the bug

Using the addRotationSingleUser call against an RDS database cluster creates a lambda via the Serverless Application Repository. At present the code for this application points to version 1.1.225 of the application, which uses Python 3.7, which is now EOL.

From checking the AWS console, a newer version is available (1.1.367) which uses Python 3.9, which is still within security support.

Expected Behavior

Rotation lambda uses a supported python runtime.

Current Behavior

Rotation lambda uses an unsupported python runtime.

Reproduction Steps

Deploy a rotation lambda using addRotationSingleUser (we're using Postgres but I'm pretty sure this will affect all RDS platforms)

Possible Solution

Update the version used against the Serverless Application Repository to 1.1.367

Additional Information/Context

No response

CDK CLI Version

2.83.0

Framework Version

No response

Node.js Version

18

OS

Mac OS

Language

Typescript

Language Version

No response

Other information

No response
@wilhen01 wilhen01 added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Aug 24, 2023
@github-actions github-actions bot added the @aws-cdk/aws-rds Related to Amazon Relational Database label Aug 24, 2023
@wilhen01
Copy link
Contributor Author

Worth noting that ideally there would be a version of this Serverless Application which runs on Python 3.11...but I appreciate that's probably not within the control of the CDK team. If anyone has any leverage they'd like to apply on the team which maintains those Serverless Applications, that would be awesome 😁

@pahud
Copy link
Contributor

pahud commented Aug 24, 2023

Yes I noticed you have reported to the upstream aws-samples/aws-secrets-manager-rotation-lambdas#119 Thank you. For now, we probably can create a PR to bump the version to 1.1.367. Are you interested to submit a PR for that?

@pahud pahud added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Aug 24, 2023
@wilhen01
Copy link
Contributor Author

I could potentially submit a PR for it! I'll see if I can find some time tomorrow 👍

@wilhen01 wilhen01 mentioned this issue Aug 25, 2023
Merged
@mergify mergify bot closed this as completed in #26884 Aug 25, 2023
mergify bot pushed a commit that referenced this issue Aug 25, 2023
@wilhen01
fix(secrets-manager): SecretRotationApplication creates lambda on pyt…
2d9d8d6 
…hon 3.7 which is EOL (#26884)

Update `SecretRotationApplication` versions to `1.1.367` - the latest available in the Serverless Application Repository. This will bump the deployed lambdas from Python 3.7 (which is EOL) to Python 3.9 (which is still within security support).

Closes #26866.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot mentioned this issue Sep 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database bug This issue is a bug. effort/small Small work item – less than a day of effort p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(secrets-manager): SecretRotationApplication creates lambda on python 3.7 which is EOL
2 participants
@pahud @wilhen01