Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_events_targets: AwsApi still on node 14 #26963

Closed
juweeks opened this issue Sep 1, 2023 · 4 comments
Closed

aws_events_targets: AwsApi still on node 14 #26963

juweeks opened this issue Sep 1, 2023 · 4 comments
Labels

Comments

@juweeks
Copy link

juweeks commented Sep 1, 2023

Describe the bug

AwsApi stll on node v14. needs upgrade before that runtime is deprecated.

Expected Behavior

node >14

Current Behavior

node == 14

Reproduction Steps

evt.AwsApi(
service="Amplify",
action="startDeployment",
policy_statement=iam.PolicyStatement(
actions=[
"amplify:StartDeployment",
"s3:DeleteObject",
"s3:GetObject",
"s3:GetObjectAcl",
"s3:ListBucket",
"s3:PutObject",
"s3:PutObjectAcl",
"s3:PutObjectVersionAcl",
],
resources=[fdfdasfds],
),
parameters=dict(appId=webapp.app_id, branchName=branch, sourceUrl=fdfdsds)
),
)

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.91

Framework Version

2.91

Node.js Version

v20.5.1

OS

mac 13.4.1

Language

Python

Language Version

3.9.6

Other information

No response

@juweeks juweeks added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Sep 1, 2023
@cm-dyoshikawa
Copy link

It seems to have been resolved recently.

#26921

@juweeks
Copy link
Author

juweeks commented Sep 1, 2023

good catch. thanks!

@juweeks juweeks closed this as completed Sep 1, 2023
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@jacklin213
Copy link
Member

For anyone that stumbles upon this issue, the fix which was called out above has been released in version 2.94.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants