Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-cdk-lib: Missing tags when cfn is synthesized from the app #27024

Closed
xavi-bean opened this issue Sep 6, 2023 · 2 comments
Closed

aws-cdk-lib: Missing tags when cfn is synthesized from the app #27024

xavi-bean opened this issue Sep 6, 2023 · 2 comments
Labels
aws-cdk-lib Related to the aws-cdk-lib package bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.

Comments

@xavi-bean
Copy link

xavi-bean commented Sep 6, 2023

Describe the bug

When adding stack tags using Tags.of(stackname).add("key", "value") it works great until CDK version 2.87. However, when synthesizing the stacks using cdk versions >=2.88 (latest version 2.94 also tested and failing) the tags disappear from the stacks.

Expected Behavior

Tags should apply to all child constructs once the stack is synthesized, the same way it has been doing until aws-cdk-lib version <=2.87.

Current Behavior

Tags are not generated when the stacks are built.

Reproduction Steps

I apply tags at stack entry point level through app.py, the same way showed in the documentation Tags.of(stackname).add("key", "value") (this has been working until v.2.87).

Possible Solution

No response

Additional Information/Context

This is similar (or the same) bug that was reported in past: #26169. Apparently this was fixed in cdk v. 2.87 (it appears in its changelog) but seems broke again in versions >=2.88.
Have opened a case to aws support and they have said me to open this issue in order to be able to publicly track its fixing status.

CDK CLI Version

2.94

Framework Version

No response

Node.js Version

20.3.0

OS

Linux / macOS

Language

Python

Language Version

No response

Other information

No response

@xavi-bean xavi-bean added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Sep 6, 2023
@github-actions github-actions bot added the aws-cdk-lib Related to the aws-cdk-lib package label Sep 6, 2023
@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Sep 6, 2023
@peterwoodworth
Copy link
Contributor

There was a similar issue reported here - It seems to me that the issue starts appearing on 2.81.0 using the code in that issue. Could you please provide a reproduction snippet if it's 2.88.0 where you start seeing the issue?

@peterwoodworth peterwoodworth added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Sep 6, 2023
@khushail khushail removed the investigating This issue is being investigated and/or work is in progress to resolve the issue. label Sep 6, 2023
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws-cdk-lib Related to the aws-cdk-lib package bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.
Projects
None yet
Development

No branches or pull requests

3 participants