Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_ecs_patterns: ScheduledFargateTask (and others) #27517

Open
mrtngrbmn opened this issue Oct 12, 2023 · 5 comments
Open

aws_ecs_patterns: ScheduledFargateTask (and others) #27517

mrtngrbmn opened this issue Oct 12, 2023 · 5 comments
Labels
@aws-cdk/aws-ecs-patterns Related to ecs-patterns library documentation This is a problem with documentation. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@mrtngrbmn
Copy link

Describe the issue

In aws_ecs_pattern.ScheduledFargateTask there are

  • scheduled_fargate_task_definition_options
  • scheduled_fargate_task_image_options
  • task_definition

Difference between the first is clear, but how is the task_definition parameter is related to them?
What is the meaning of "[disable-awslint:ref-via-interface] Default: - none"?

In aws_ecs_patterns.ScheduledFargateTaskDefinitionOptions:
"Image or taskDefinition must be specified, but not both. [disable-awslint:ref-via-interface]" is stated, what makes no sense here.

In aws_ecs_patterns.ScheduledFargateTaskImageOptions:
The parameter
"task_definition (Optional[FargateTaskDefinition]) – The task definition to use for tasks in the service. TaskDefinition or TaskImageOptions must be specified, but not both. [disable-awslint:ref-via-interface] Default: - none"
is not clear to me and how it make sense here.

Links

https://docs.aws.amazon.com/cdk/api/v2/python/aws_cdk.aws_ecs_patterns/ScheduledFargateTask.html
https://docs.aws.amazon.com/cdk/api/v2/python/aws_cdk.aws_ecs_patterns/ScheduledFargateTaskImageOptions.html
https://docs.aws.amazon.com/cdk/api/v2/python/aws_cdk.aws_ecs_patterns/ScheduledFargateTaskDefinitionOptions.html

@mrtngrbmn mrtngrbmn added documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged. labels Oct 12, 2023
@github-actions github-actions bot added the @aws-cdk/aws-ecs-patterns Related to ecs-patterns library label Oct 12, 2023
@peterwoodworth
Copy link
Contributor

There were warnings added to call this out - are you seeing these warnings? #26737

@peterwoodworth peterwoodworth added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. and removed needs-triage This issue or PR still needs to be triaged. labels Oct 12, 2023
@mrtngrbmn
Copy link
Author

No. I'm using ScheduledFargateTaskImageOptions with some parameters and the task_definition parameter. There is no warning, neither for cdk synth nor for cdk deploy.

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Oct 13, 2023
@peterwoodworth
Copy link
Contributor

Well, the warning will pop up if you use the high level taskDefinition parameter. This was done because the taskDefinition prop originates from extending another construct, but on this higher level construct it's redundant. However the docs generation won't know that and know how to give it a different docstring, which is why the warning was added

If the difference between the first two is clear, then that's as good as we can do here in terms of documentation

@peterwoodworth peterwoodworth added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Oct 16, 2023
@github-actions
Copy link

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Oct 19, 2023
@mrtngrbmn
Copy link
Author

Difference between the first two is clear. Just a request to update the documentation.

@github-actions github-actions bot removed closing-soon This issue will automatically close in 4 days unless further comments are made. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. labels Oct 19, 2023
@tim-finnigan tim-finnigan added p2 feature-request A feature should be added or improved. effort/small Small work item – less than a day of effort labels Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ecs-patterns Related to ecs-patterns library documentation This is a problem with documentation. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

3 participants