Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-opensearchservice: No support for IM4GN instances #27757

Closed
ksco92 opened this issue Oct 30, 2023 · 4 comments · Fixed by #27765
Closed

aws-opensearchservice: No support for IM4GN instances #27757

ksco92 opened this issue Oct 30, 2023 · 4 comments · Fixed by #27765
Labels
@aws-cdk/aws-opensearch Related to the @aws-cdk/aws-opensearchservice package bug This issue is a bug. effort/small Small work item – less than a day of effort p2

Comments

@ksco92
Copy link

ksco92 commented Oct 30, 2023 •
edited
Loading

Describe the bug

No support for IM4GN instances:

aws-cdk/packages/aws-cdk-lib/aws-opensearchservice/lib/domain.ts

Lines 1544 to 1548 in 72bf499

// Only R3, I3 and r6gd support instance storage, per
// https://aws.amazon.com/opensearch-service/pricing/
if (!ebsEnabled && !isEveryDatanodeInstanceType('r3', 'i3', 'r6gd')) {
throw new Error('EBS volumes are required when using instance types other than r3, i3 or r6gd.');
}

IM4GN instances don't support EBS. Upgrading to IM4GN makes cdk deployments fail.

Expected Behavior

IM4GN deployments are supported.

Current Behavior

Error message on build:

Error: EBS volumes are required when using instance types other than r3, i3 or r6gd.

Reproduction Steps

Change the instances type to any IM4GN instance in OS.

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

Latest

Framework Version

No response

Node.js Version

Latest

OS

MacOS

Language

TypeScript

Language Version

No response

Other information

No response
@ksco92 ksco92 added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Oct 30, 2023
@github-actions github-actions bot added the @aws-cdk/aws-opensearch Related to the @aws-cdk/aws-opensearchservice package label Oct 30, 2023
@msambol
Copy link
Contributor

msambol commented Oct 30, 2023

I'll take this.

@msambol msambol mentioned this issue Oct 30, 2023
Merged
@khushail
Copy link
Contributor

Thanks @ksco92 for reporting this.

Thanks @msambol for submitting the PR.

@khushail khushail added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Oct 30, 2023
@ksco92
Copy link
Author

ksco92 commented Oct 31, 2023

Thanks for the quick turnaround, what is the timeline for this to be released now?

@github-actions github-actions bot mentioned this issue Nov 1, 2023
Closed
@mergify mergify bot closed this as completed in #27765 Nov 2, 2023
mergify bot pushed a commit that referenced this issue Nov 2, 2023
@msambol
fix(opensearchservice): IM4GN instances don't support EBS (#27765)
af1f6bd 
Relevant docs https://aws.amazon.com/opensearch-service/pricing/

Closes #27757.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-opensearch Related to the @aws-cdk/aws-opensearchservice package bug This issue is a bug. effort/small Small work item – less than a day of effort p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(opensearchservice): IM4GN instances don't support EBS msambol/aws-cdk
3 participants
@msambol @ksco92 @khushail