Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-cdk-lib.aws_cognito.UserPool: reference to non-existent selfSignUp property #27829

Closed
ppena-LiveData opened this issue Nov 3, 2023 · 1 comment · Fixed by #27872
Closed

aws-cdk-lib.aws_cognito.UserPool: reference to non-existent selfSignUp property #27829

ppena-LiveData opened this issue Nov 3, 2023 · 1 comment · Fixed by #27872
Labels
@aws-cdk/aws-cognito Related to Amazon Cognito documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged.

Comments

@ppena-LiveData
Copy link

ppena-LiveData commented Nov 3, 2023 •
edited
Loading

Describe the issue

The documentation for the aws_cognito.UserPool.selfSignUpEnabled field says, "This can be further configured via the selfSignUp property," but a selfSignUp property does not appear to exist.

Maybe instead of the selfSignUp property, this should refer to the userVerification property?

Links

https://github.com/aws/aws-cdk/blob/fce26b635d0ef2c443ca6d4e390a90f586130f05/packages/aws-cdk-lib/aws-cognito/lib/user-pool.ts#L527C1-L531C40
@ppena-LiveData ppena-LiveData added documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged. labels Nov 3, 2023
@github-actions github-actions bot added the @aws-cdk/aws-cognito Related to Amazon Cognito label Nov 3, 2023
@lpizzinidev lpizzinidev mentioned this issue Nov 7, 2023
Merged
mergify bot added a commit to lpizzinidev/aws-cdk that referenced this issue Nov 7, 2023
@mergify
Merge branch 'main' into awsgh-27829
33f3161
@mergify mergify bot closed this as completed in #27872 Nov 7, 2023
mergify bot pushed a commit that referenced this issue Nov 7, 2023
@lpizzinidev
docs(cognito): update selfSignUpEnabled documentation (#27872)
2d0c1d0 
Removes reference to non-existing `selfSignUp` attribute and adjusts formatting.

Closes #27829.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

mikewrighton pushed a commit that referenced this issue Nov 13, 2023
@lpizzinidev
docs(cognito): update selfSignUpEnabled documentation (#27872)
c2a6f97 
Removes reference to non-existing `selfSignUp` attribute and adjusts formatting.

Closes #27829.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions github-actions bot mentioned this issue Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-cognito Related to Amazon Cognito documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(cognito): update selfSignUpEnabled documentation lpizzinidev/aws-cdk
1 participant
@ppena-LiveData