Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-cdk-lib: CfnOriginAccessControl does not give error message for name that is too long #28030

Closed
euanw-cgi opened this issue Nov 16, 2023 · 6 comments
Labels
aws-cdk-lib Related to the aws-cdk-lib package bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.

Comments

@euanw-cgi
Copy link

Describe the bug

When you have a CfnOriginAccessControl configuration with an originAccessControlConfig with a name parameter that is too long it does not highlight this in the given error message:

Resource handler returned message: "Invalid request provided: AWS::CloudFront::OriginAccessControl" (RequestToken: 1aafb6fa-72fe-4ce0-08be-523c109c03c1, HandlerErrorCode: InvalidRequest)

You just get a Invalid request response.

Expected Behavior

Error message should highlight that the name parameter is too long.

Current Behavior

Error message does not reflect why the request is invalid.

Reproduction Steps

Create a CfnOriginAccessControl resource with a very long name.

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.109.0

Framework Version

No response

Node.js Version

v20.3.0

OS

WSL

Language

TypeScript

Language Version

No response

Other information

No response

@euanw-cgi euanw-cgi added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Nov 16, 2023
@github-actions github-actions bot added the aws-cdk-lib Related to the aws-cdk-lib package label Nov 16, 2023
@msambol
Copy link
Contributor

msambol commented Nov 16, 2023

I'll take this.

@pahud
Copy link
Contributor

pahud commented Nov 16, 2023

@msambol Thank you! Yes we should capture that in CDK.

@pahud pahud added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Nov 16, 2023
@msambol
Copy link
Contributor

msambol commented Nov 16, 2023

@pahud I took a look.. it's a generated file so I don't think it's possible?

@euanw-cgi
Copy link
Author

cdk synth works, but cdk deploy does not

@pahud
Copy link
Contributor

pahud commented Jun 4, 2024

@euanw-cgi

Are you still having this issue? Can you provide some minimal code snippet so we can address and get it fixed?

@pahud pahud added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Jun 4, 2024
Copy link

github-actions bot commented Jun 6, 2024

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws-cdk-lib Related to the aws-cdk-lib package bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.
Projects
None yet
Development

No branches or pull requests

3 participants