Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-batch: support runtimePlatform for EcsFargateContainerDefinition #28188

Closed
1 of 2 tasks
chriskeyser opened this issue Nov 29, 2023 · 3 comments
Closed
1 of 2 tasks

aws-batch: support runtimePlatform for EcsFargateContainerDefinition #28188

chriskeyser opened this issue Nov 29, 2023 · 3 comments
Labels
@aws-cdk/aws-batch Related to AWS Batch duplicate This issue is a duplicate. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@chriskeyser
Copy link

Describe the feature

Add runtimePlatform to EcsFargateContainerDefinition so an ARM platform can be specified. In order to use ARM I need to drop down to the low level construct, CfnJobDefinition.

Use Case

We use golang and compile for ARM. ARM resources give us consistent compute (no hyperthreading) and is more economical.

Proposed Solution

Add the runtimePlatform information to the higher level EcsFargateContainerDefinition construct.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

^2.97.0

Environment details (OS name and version, etc.)

dev - mac/ventura, runtime: amazon linux 2 / arm
@chriskeyser chriskeyser added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 29, 2023
@github-actions github-actions bot added the @aws-cdk/aws-batch Related to AWS Batch label Nov 29, 2023
@khushail
Copy link
Contributor

Hi @chriskeyser ,thanks for submitting this. There is already a FR for the same, so I am marking this as duplicate.

However, thanks for volunteering to contribute on this. Please feel free to work on this and team would be happy to review your PR.

@khushail khushail added p2 effort/small Small work item – less than a day of effort duplicate This issue is a duplicate. and removed needs-triage This issue or PR still needs to be triaged. labels Nov 29, 2023
@github-actions github-actions bot mentioned this issue Dec 1, 2023
Closed
@gracelu0
Copy link
Contributor

Closing this issue as it is a duplicate and has been addressed by #28841.

@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-batch Related to AWS Batch duplicate This issue is a duplicate. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chriskeyser @gracelu0 @khushail