Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDK: Support EKS Managed Node Group EDP discounts for spot #28492

Open
2 tasks
avshabavsha opened this issue Dec 26, 2023 · 4 comments
Open
2 tasks

CDK: Support EKS Managed Node Group EDP discounts for spot #28492

avshabavsha opened this issue Dec 26, 2023 · 4 comments
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@avshabavsha
Copy link

Describe the feature

Add ability to inject context id to enable EDP discounts for spot for EKS Managed Node Group (in CDK Typescript).

Use Case

I am unable to inject relevant context id for EKS manage node group to enable EDP discounts for spot instances. Used method cluster.addNodegroupCapacity(...) and passing parameter of launchTemplateSpec.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.99.1

Environment details (OS name and version, etc.)

Linux

@avshabavsha avshabavsha added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Dec 26, 2023
@github-actions github-actions bot added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Dec 26, 2023
@pahud
Copy link
Contributor

pahud commented Dec 26, 2023

This is interesting. Can you share more details about how to inject the context ID for the managed nodegroup? Is it a Tag or label? Can you share more tech details about that?

@pahud pahud added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Dec 26, 2023
Copy link

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Dec 28, 2023
@github-actions github-actions bot added closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jan 2, 2024
@github-actions github-actions bot closed this as completed Jan 2, 2024
@evgenyka evgenyka reopened this Jan 3, 2024
@evgenyka
Copy link
Contributor

evgenyka commented Jan 3, 2024

Pending extra information from the customer about context ID.

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Jan 3, 2024
@GoldenBoy1980
Copy link

As an AWS customer that has access to a Conditional Pricing deal, the customer can take advantage of low prices on EC2 Spot usage by requesting for instances using EC2 Auto Scaling Groups, Amazon EC2 Spot Fleet API, or Amazon EC2 Fleet API and specifying the deal Context as part of your launch request.
The API request will be as follows: aws create-fleet --context context-XXX
The request from CDK is exactly as Karpenter support it here:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

4 participants