Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LambdaInvoke: Warn legacy state type will be deployed with payloadResponseOnly #28950

Open
2 tasks
deeheber opened this issue Feb 1, 2024 · 2 comments
Open
2 tasks
Labels
@aws-cdk/aws-lambda Related to AWS Lambda effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@deeheber
Copy link

deeheber commented Feb 1, 2024

Describe the feature

After lots of digging around I realized that under the hood when someone adds payloadResponseOnly: true to the LambdaInvoke class it will implement an older version of this state type.

I had no idea until months later I saw the type Task: lambda (legacy):invoke in the console.

Feature idea: It would be nice to have a warning in the IDE types or in the CLI console when doing a synth or deploy.

Use Case

The use case would be to pre-warn folks like myself who don't go into the AWS console too often that adding this property will result in the non-optimized lambda invoke state type in their state machine. They can then quickly decide if that's ok or not for them.

It can also save folks lots of time debugging to try to figure out why this is happening. Example: I'm an AWS Hero and it took me 2hrs to finally figure this out.

Proposed Solution

No response

Other Information

Thanks for reading and for the great work on this project. 🚀

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.124.0

Environment details (OS name and version, etc.)

Mac OS Sonoma 14.2.1

@deeheber deeheber added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 1, 2024
@github-actions github-actions bot added the @aws-cdk/aws-lambda Related to AWS Lambda label Feb 1, 2024
@pahud
Copy link
Contributor

pahud commented Feb 5, 2024

Thank you. Are you interested to submit a PR for that?

@pahud pahud added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Feb 5, 2024
@deeheber
Copy link
Author

deeheber commented Feb 6, 2024

Hey @pahud thanks for the reply.

At this time, I'm rather busy and don't have the time to contribute a PR for this. Feel free to assign this task to someone else.

I can keep an eye on this issue and if it's not resolved when I do have some more time, happy to take a look into a contribution. That will probably be about 2-3 months in the future though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-lambda Related to AWS Lambda effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

2 participants