Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-servicecatalog): ProductStack Env #29219

Open
2 tasks
J11522 opened this issue Feb 22, 2024 · 3 comments
Open
2 tasks

(aws-servicecatalog): ProductStack Env #29219

J11522 opened this issue Feb 22, 2024 · 3 comments
Labels
@aws-cdk/aws-servicecatalog Related to AWS Service Catalog effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p3

Comments

@J11522
Copy link
Contributor

J11522 commented Feb 22, 2024

Describe the feature

We want to be able to specify the env for the ProductStack, ie. account and/or region.

Use Case

In CDK Pipeline currently the ProductStack takes its env from the stage.
In our usecase we need the Product to either be account agnostic or use an account different from the stage.

However, for cross-region deployments an account needs to be specified on the stage.
This results in breaking behaviour with our account requirement from above

Proposed Solution

Expose an env property similar to regular stacks

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.129.0

Environment details (OS name and version, etc.)

Mac

@J11522 J11522 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 22, 2024
@github-actions github-actions bot added the @aws-cdk/aws-servicecatalog Related to AWS Service Catalog label Feb 22, 2024
@tim-finnigan tim-finnigan self-assigned this Feb 22, 2024
@tim-finnigan tim-finnigan added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Feb 22, 2024
@tim-finnigan
Copy link

Thanks for the feature request. There is an environment property on ProductStack, but it sounds like what you're requesting may overlap with #24757 - can you confirm?

@tim-finnigan tim-finnigan added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Feb 22, 2024
@tim-finnigan tim-finnigan removed their assignment Feb 22, 2024
@J11522
Copy link
Contributor Author

J11522 commented Feb 22, 2024

You are right, there is an environment property on the ProductStack. However, this is readonly.
The issue #24757 suggests something similar, but has a subtle difference as I can tell.

In the issue, the goal is to use the scope of the ProductStack as the source of the env. While, IMHO, his seems logical, this is in contrast to the regular stack behaviour.

What I suggest is along the line of the regular stack behaviour that one can explicilty provide the env for the stack.

Basically, what I request is to make the environment property available to the user by exposing it through the props similar to how it is with StackProps https://github.com/aws/aws-cdk/blob/v2.129.0/packages/aws-cdk-lib/core/lib/stack.ts#L50

@tim-finnigan
Copy link

Thanks for following up, we can track this issue to get more input/discussion.

@tim-finnigan tim-finnigan added p2 effort/medium Medium work item – several days of effort and removed response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. labels Feb 22, 2024
@pahud pahud added p3 and removed p2 labels Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-servicecatalog Related to AWS Service Catalog effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p3
Projects
None yet
Development

No branches or pull requests

3 participants