Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve SSM AMIs during synth if possible #2933

Closed
eladb opened this issue Jun 19, 2019 · 1 comment
Closed

Resolve SSM AMIs during synth if possible #2933

eladb opened this issue Jun 19, 2019 · 1 comment
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud @aws-cdk/aws-ecs Related to Amazon Elastic Container @aws-cdk/aws-route53 Related to Amazon Route 53 @aws-cdk/core Related to core CDK functionality closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. needs-discussion This issue/PR requires more discussion with community. p2

Comments

@eladb
Copy link
Contributor

eladb commented Jun 19, 2019

The use of the SSM context provider by the EC2 and ECS libraries to retrieve AMIs was
replaced by deploy-time resolution of SSM parameters, so no fallback is required.

I think this is not great to do for all cases. The whole point of context was to do controlled updates. For example, if I just update my application to add a queue and deploy, or I change something to do a hotfix, is it okay that I pull in a new AMI with a new version of Amazon Linux and a different version of libfoobar.so.5 which happens to contain a bug and now my application is broken?

The point of context was that you would explicitly opt in to updates to "critical" parameters like that.

It's fine to fallback to the generic behavior (imo) only if we can't do anything else, so if the stack is region-agnostic. If the stack is region-aware, we can and should do better.

Originally posted by @rix0rrr in #2922

@NGL321 NGL321 added @aws-cdk/core Related to core CDK functionality @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud @aws-cdk/aws-ecs Related to Amazon Elastic Container feature-request A feature should be added or improved. @aws-cdk/aws-route53 Related to Amazon Route 53 labels Jun 20, 2019
@eladb eladb assigned eladb and shivlaks and unassigned rix0rrr and eladb Aug 12, 2019
@shivlaks shivlaks added needs-discussion This issue/PR requires more discussion with community. effort/medium Medium work item – several days of effort labels Feb 6, 2020
@shivlaks shivlaks added the p2 label Aug 31, 2020
@NGL321 NGL321 assigned njlynch and unassigned shivlaks Jan 25, 2021
@github-actions
Copy link

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud @aws-cdk/aws-ecs Related to Amazon Elastic Container @aws-cdk/aws-route53 Related to Amazon Route 53 @aws-cdk/core Related to core CDK functionality closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. needs-discussion This issue/PR requires more discussion with community. p2
Projects
None yet
Development

No branches or pull requests

5 participants