Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "feat(cli): warn of non-existent stacks in cdk destroy" #29577

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

scanlonp
Copy link
Contributor

Reverts #27921

Failing in the test pipeline on this test where it was not erroring out as it should have. The error here is not being thrown.

@github-actions github-actions bot added the p2 label Mar 22, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team March 22, 2024 07:13
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 22, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Mar 22, 2024
@colifran colifran changed the title Revert "feat(cli): warn of non-existent stacks in cdk destroy" revert: "feat(cli): warn of non-existent stacks in cdk destroy" Mar 22, 2024
@aws-cdk-automation
Copy link
Collaborator

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

@vinayak-kukreja vinayak-kukreja added the pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested label Mar 25, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 25, 2024 18:07

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-cli-test-run This PR needs CLI tests run against it. label Mar 25, 2024
Copy link
Contributor

mergify bot commented Mar 25, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 5137b95
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit f60e6e9 into main Mar 25, 2024
11 of 12 checks passed
@mergify mergify bot deleted the revert-27921-fix/destroy-not-exits branch March 25, 2024 18:37
Copy link
Contributor

mergify bot commented Mar 25, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants