Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_eks: Add ImagePullSecrets support to cluster.addServiceAccount #29696

Open
2 tasks
lumattr opened this issue Apr 2, 2024 · 1 comment
Open
2 tasks

aws_eks: Add ImagePullSecrets support to cluster.addServiceAccount #29696

lumattr opened this issue Apr 2, 2024 · 1 comment
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@lumattr
Copy link

lumattr commented Apr 2, 2024

Describe the feature

K8s now supports to ability to add registry credentials to the Service account for services. but there isnt a way to add those details through the cdk helper functions. only throu

Use Case

Id like to be able to continue using the helpers

Proposed Solution

No response

Other Information

https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/#verify-that-imagepullsecrets-are-set-for-new-pods

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.118.0

Environment details (OS name and version, etc.)

Ubuntu 22.04.3 LTS
@lumattr lumattr added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 2, 2024
@github-actions github-actions bot added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Apr 2, 2024
@tim-finnigan tim-finnigan self-assigned this Apr 3, 2024
@tim-finnigan tim-finnigan added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Apr 3, 2024
@tim-finnigan
Copy link

Thanks for the feature request!

@tim-finnigan tim-finnigan added p2 effort/medium Medium work item – several days of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Apr 3, 2024
@tim-finnigan tim-finnigan removed their assignment Apr 3, 2024
@github-actions github-actions bot mentioned this issue Apr 8, 2024
Closed
@github-actions github-actions bot mentioned this issue May 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tim-finnigan @lumattr