AWS CDK CLI: China partition not taken into account when validating notification Sns Topic

[LennartC]

Describe the bug

The cdk deploy commands allows you to specify SNS topics for CloudFormation notifications with the --notification-arns option.

However, when deploying in a China region, with a valid SNS Topic in China, the command will error out with:

Notification arn arn:aws-cn:sns:cn-northwest-1:012345678901:topic is not a valid arn for an SNS topic

Expected Behavior

The CLI should allow the China partition (aws-cn) when validating the SNS topic.

Current Behavior

The CLI exits.

Reproduction Steps

cdk deploy --notification-arns arn:aws-cn:sns:cn-northwest-1:012345678901:my-topic

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.135.0

Framework Version

No response

Node.js Version

v18.18.2

OS

Ubuntu

Language

TypeScript

Language Version

No response

Other information

No response

[nmussy]

The validation regex is less than ideal, we should probably switch to using Arn.split instead:

aws-cdk/packages/aws-cdk/lib/util/validate-notification-arn.ts

Lines 4 to 6 in b82320b

	export function validateSnsTopicArn(arn: string): boolean {
	return /^arn:aws:sns:[a-z0-9\-]+:[0-9]+:[a-z0-9\-\_]+$/i.test(arn);
	}

[tim-finnigan]

Thanks for reporting this issue and creating the PR. I agree with the comment above that using split() is probably the better approach to account for partitions in ARNs.