fix: cdk diff prints upgrade bootstrap warning even when current version exceeds the recommended version #29938

vinayak-kukreja · 2024-04-23T19:56:16Z

Reason for this change

Currently, we just check for if a minimum bootstrap version is needed for a functionality and give a warning. But, we do not check the bootstrap version of the stack itself. This gives a confusing warning for upgrading to a bootstrap version (example: version 8) when the stack bootstrap version is already higher than the recommended version.

Description of changes

We cannot know successfully what the bootstrap version is in the AWS account without the lookup role. We are getting this warning while trying to assume the lookup role and failing to assume it.

I am removing upgrade related warnings since we are emitting them without any confirmation of the user's account bootstrap version. This will lead to confusion. Instead, I am trying to make some of the existing error messages more clear.

Description of how you validated changes

Updated unit tests.
Will run this through test pipeline.

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…ion exceeds the recommended version Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>

aws-cdk-automation

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>

vinayak-kukreja · 2024-04-24T21:14:21Z

packages/aws-cdk/lib/api/deployments.ts

@@ -532,7 +532,7 @@ export class Deployments {

    // try to assume the lookup role
    const warningMessage = `Could not assume ${arns.lookupRoleArn}, proceeding anyway.`;
-    const upgradeMessage = `(To get rid of this warning, please upgrade to bootstrap version >= ${stack.lookupRole?.requiresBootstrapStackVersion})`;


If we are unable to assume the lookup role and are not looking for the bootstrap version in SSM of the user's account, then there is no way we are sure about this recommendation. And, we should not just be recommending this without knowing it for a fact that they are on an older version of bootstrap.

We already error out if the user is using an older version of bootstrap than the recommended version.

comcalvi · 2024-04-25T15:20:58Z

packages/aws-cdk/test/cdk-toolkit.test.ts

@@ -241,7 +241,6 @@ describe('readCurrentTemplate', () => {
    // THEN
    expect(flatten(stderrMock.mock.calls)).toEqual(expect.arrayContaining([
      expect.stringMatching(/Could not assume bloop-lookup:here:123456789012/),
-      expect.stringMatching(/please upgrade to bootstrap version >= 5/),


This one has an invalid bootstrap version (1 when >= 5 was expected) and an upgrade message should be emitted here

This is weird. Without successfully assuming the lookup role, how will we know what bootstrap version is in SSM. Maybe cached? Taking a look

But, if we are able to assume the role, we do throw in such scenario instead of a warning: https://github.com/aws/aws-cdk/blob/vkukreja/doc-update/packages/aws-cdk/lib/api/deployments.ts#L546-L549

So it was throwing the expected error but since we catch it and do nothing, it will only show up if we have --debug flag enabled. I believe it needs to be shown and hence adding it with error

Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

mergify · 2024-04-26T21:52:16Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2024-04-26T22:43:23Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 34c6f06
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2024-04-26T22:43:44Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2024-07-25T21:13:55Z

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

fix: cdk diff prints upgrade bootstrap warning even when current vers…

6584df3

…ion exceeds the recommended version Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>

aws-cdk-automation requested a review from a team April 23, 2024 19:56

github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p2 labels Apr 23, 2024

mergify bot added the contribution/core This is a PR that came from AWS. label Apr 23, 2024

vinayak-kukreja had a problem deploying to test-pipeline April 23, 2024 19:57 — with GitHub Actions Failure

aws-cdk-automation previously requested changes Apr 23, 2024

View reviewed changes

make updates

53833ac

Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>

vinayak-kukreja had a problem deploying to test-pipeline April 23, 2024 20:16 — with GitHub Actions Failure

make updates

8b45d2c

Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>

vinayak-kukreja had a problem deploying to test-pipeline April 23, 2024 20:19 — with GitHub Actions Failure

changing PR direction

9257166

Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>

vinayak-kukreja had a problem deploying to test-pipeline April 23, 2024 23:11 — with GitHub Actions Failure

Merge branch 'main' into vkukreja/doc-update

8208671

vinayak-kukreja temporarily deployed to test-pipeline April 23, 2024 23:12 — with GitHub Actions Inactive

vinayak-kukreja marked this pull request as ready for review April 23, 2024 23:15

vinayak-kukreja added the pr/do-not-merge This PR should not be merged at this time. label Apr 24, 2024

vinayak-kukreja commented Apr 24, 2024

View reviewed changes

comcalvi requested changes Apr 25, 2024

View reviewed changes

Merge branch 'main' into vkukreja/doc-update

931e7a2

vinayak-kukreja had a problem deploying to test-pipeline April 25, 2024 16:17 — with GitHub Actions Failure

add bootstrap version old thrown error to stderr stream

d5802b3

Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>

vinayak-kukreja had a problem deploying to test-pipeline April 25, 2024 18:24 — with GitHub Actions Failure

update error import

a820099

Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>

vinayak-kukreja had a problem deploying to test-pipeline April 25, 2024 18:27 — with GitHub Actions Failure

update wording

16f04c8

Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>

vinayak-kukreja had a problem deploying to test-pipeline April 25, 2024 18:30 — with GitHub Actions Failure

update wording

24bbb1a

Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>

vinayak-kukreja temporarily deployed to test-pipeline April 25, 2024 18:31 — with GitHub Actions Inactive

vinayak-kukreja added the pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested label Apr 26, 2024

vinayak-kukreja removed the pr/do-not-merge This PR should not be merged at this time. label Apr 26, 2024

Merge branch 'main' into vkukreja/doc-update

34c6f06

mergify bot had a problem deploying to test-pipeline April 26, 2024 22:17 Failure

mergify bot merged commit 28b0080 into main Apr 26, 2024
11 of 12 checks passed

mergify bot deleted the vkukreja/doc-update branch April 26, 2024 22:43

This was referenced Apr 26, 2024

Weekly PR metrics report #29986

Closed

Weekly PR metrics report #29994

Closed

Monthly PR metrics report #30026

Closed

NOUIY mentioned this pull request May 24, 2024

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#99

Open

kazimanzurrashid mentioned this pull request May 25, 2024

[Snyk] Upgrade aws-cdk-lib from 2.139.1 to 2.140.0 kazimanzurrashid/aws-scheduler-go#811

Closed

rwlxxvii mentioned this pull request May 27, 2024

[Snyk] Upgrade aws-cdk-lib from 2.136.1 to 2.140.0 rwlxxvii/containers#124

Merged

NOUIY mentioned this pull request May 30, 2024

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#101

Open

NOUIY mentioned this pull request Jun 7, 2024

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#102

Open

niravparikh05 mentioned this pull request Jun 13, 2024

[Snyk] Upgrade aws-cdk from 2.65.0 to 2.142.1 paralus/eks-blueprints-addon#3

Open

NOUIY mentioned this pull request Jun 14, 2024

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#103

Open

snyk-io bot mentioned this pull request Jun 20, 2024

[Snyk] Upgrade aws-cdk-lib from 2.138.0 to 2.143.1 Opetushallitus/heratepalvelu#280

Open

NOUIY mentioned this pull request Jun 20, 2024

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#104

Open

snyk-io bot mentioned this pull request Jun 21, 2024

[Snyk] Upgrade aws-cdk-lib from 2.139.0 to 2.143.1 Opetushallitus/ovara#36

Open

rwlxxvii mentioned this pull request Jun 22, 2024

[Snyk] Upgrade aws-cdk-lib from 2.139.0 to 2.144.0 rwlxxvii/containers#140

Merged

This was referenced Jun 22, 2024

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#105

Open

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#106

Open

This was referenced Jul 5, 2024

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#107

Open

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#108

Open

aws locked as resolved and limited conversation to collaborators Jul 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: cdk diff prints upgrade bootstrap warning even when current version exceeds the recommended version #29938

fix: cdk diff prints upgrade bootstrap warning even when current version exceeds the recommended version #29938

vinayak-kukreja commented Apr 23, 2024 •

edited

Loading

aws-cdk-automation left a comment

vinayak-kukreja Apr 24, 2024

comcalvi Apr 25, 2024

vinayak-kukreja Apr 25, 2024

vinayak-kukreja Apr 25, 2024

mergify bot commented Apr 26, 2024

aws-cdk-automation commented Apr 26, 2024

mergify bot commented Apr 26, 2024

aws-cdk-automation commented Jul 25, 2024

fix: cdk diff prints upgrade bootstrap warning even when current version exceeds the recommended version #29938

fix: cdk diff prints upgrade bootstrap warning even when current version exceeds the recommended version #29938

Conversation

vinayak-kukreja commented Apr 23, 2024 • edited Loading

Reason for this change

Description of changes

Description of how you validated changes

Checklist

aws-cdk-automation left a comment

Choose a reason for hiding this comment

vinayak-kukreja Apr 24, 2024

Choose a reason for hiding this comment

comcalvi Apr 25, 2024

Choose a reason for hiding this comment

vinayak-kukreja Apr 25, 2024

Choose a reason for hiding this comment

vinayak-kukreja Apr 25, 2024

Choose a reason for hiding this comment

mergify bot commented Apr 26, 2024

aws-cdk-automation commented Apr 26, 2024

AWS CodeBuild CI Report

mergify bot commented Apr 26, 2024

aws-cdk-automation commented Jul 25, 2024

vinayak-kukreja commented Apr 23, 2024 •

edited

Loading