Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bedrock: L2 Constructs #29963

Open
2 tasks
jlosito opened this issue Apr 25, 2024 · 8 comments
Open
2 tasks

bedrock: L2 Constructs #29963

jlosito opened this issue Apr 25, 2024 · 8 comments
Labels
@aws-cdk/bedrock Related to @aws-cdk/bedrock effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@jlosito
Copy link

jlosito commented Apr 25, 2024

Describe the feature

I would like to use L2 constructs to provision Bedrock related resources with sensible defaults. Now that L1 constructs have been added via #29911 , this should be possible now!

Use Case

I have been using the awslabs/generative-ai-cdk-constructs library to provision and configure Bedrock related resources, but this library makes use of custom resources to perform all of its actions. I much rather use native constructs rather than custom resources.

https://github.com/awslabs/generative-ai-cdk-constructs

Proposed Solution

If possible, use the same defaults that the generative-ai-cdk-constructs library is using for each of its L2-like constructs. In my opinion, this would make it a little bit easier to users to migrate without having to change too much. If not, that's fine too.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.139.0

Environment details (OS name and version, etc.)

macOS 14.4.1

@jlosito jlosito added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 25, 2024
@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Apr 25, 2024
@pahud
Copy link
Contributor

pahud commented Apr 25, 2024

Absolutely. Please help us prioritize with 👍 .

@hoegertn
Copy link
Contributor

If somebody from the community wants to pick it up, that is exactly what https://www.open-constructs.org/ is for.

@badmintoncryer
Copy link
Contributor

There is a Bedrock L2 construct at awslabs/generative-ai-cdk-constructs.

@jlosito
Copy link
Author

jlosito commented May 12, 2024

@badmintoncryer those are all using custom resources. It would be better if they were using leveraging the L1 constructs instead that were just introduced within the last month.

@badmintoncryer
Copy link
Contributor

badmintoncryer commented May 12, 2024

@jlosito It's true. But a PR using L1 has been created. It seems it will be replaced soon.
awslabs/generative-ai-cdk-constructs#414

@dirkmichelmycomosi
Copy link

Yes please, absolutely. Currently working with the L1s and the L2s would definitely help increase productivity.

@laithalsaadoon
Copy link

awslabs/generative-ai-cdk-constructs#414 was merged today

@krokoko
Copy link

krokoko commented May 29, 2024

@pahud @paulhcsun we did look at the contribution guide and design guidelines to contribute to the CDK our existing L2 bedrock construct mentioned above (and maybe more). We will have some changes to do to follow the guidelines, in the meantime should we open a new GitHub issue to track this effort ? Is there anything else we should do to ? Thanks !

@moelasmar moelasmar added the @aws-cdk/bedrock Related to @aws-cdk/bedrock label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/bedrock Related to @aws-cdk/bedrock effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

9 participants