feat(neptune): add copyTagsToSnapshot property to the DatabaseCluster Construct #30092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
beginning-contributor
mazyu36
changed the title
aws-cdk-automation
added
the
pr/needs-community-review
go-to-k
suggested changes
May 15, 2024
| @@ -31,6 +31,7 @@ To set up a Neptune database, define a `DatabaseCluster`. You must always launch | |||
| const cluster = new neptune.DatabaseCluster(this, 'Database', { | |||
| vpc, | |||
| instanceType: neptune.InstanceType.R5_LARGE, | |||
| copyTagsToSnapshot: true // whether to save the cluster tags when creating the snapshot. | |||
There was a problem hiding this comment.
It seems unnatural to have this property here, which is the most basic chapter. How about creating a new chapter like the Automatic minor version upgrades?
There was a problem hiding this comment.
I added a new chapter about copyTagsSnapshot.
aws-cdk-automation
removed
the
pr/needs-community-review
go-to-k
reviewed
May 15, 2024
|
|
||
| const app = new cdk.App(); | ||
|
|
||
| const stack = new cdk.Stack(app, 'aws-cdk-neptune-integ'); |
There was a problem hiding this comment.
It would be good to change the stack name so that the integ test can be deployed in parallel with other tests.
There was a problem hiding this comment.
I changed the stack name.
Co-authored-by: k.goto <24818752+go-to-k@users.noreply.github.com>
Co-authored-by: k.goto <24818752+go-to-k@users.noreply.github.com>
|
@go-to-k |
go-to-k
approved these changes
May 15, 2024
aws-cdk-automation
added
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
atanaspam
pushed a commit
to atanaspam/aws-cdk
that referenced
this pull request
Jun 3, 2024
… Construct (aws#30092) ### Issue # (if applicable) Closes aws#30087 ### Reason for this change As described in the issue. ### Description of changes Add copyTagsToSnapshot property to the DatabaseCluster Construct. ### Description of how you validated changes Add both unit tests and integ tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
vdahlberg
pushed a commit
to vdahlberg/aws-cdk
that referenced
this pull request
Jun 10, 2024
… Construct (aws#30092) ### Issue # (if applicable) Closes aws#30087 ### Reason for this change As described in the issue. ### Description of changes Add copyTagsToSnapshot property to the DatabaseCluster Construct. ### Description of how you validated changes Add both unit tests and integ tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This was referenced Jun 29, 2024
This was referenced Jul 12, 2024
This was referenced Jul 19, 2024
|
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #30087
Reason for this change
As described in the issue.
Description of changes
Add copyTagsToSnapshot property to the DatabaseCluster Construct.
Description of how you validated changes
Add both unit tests and integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license