Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stepfunctions-tasks): allow camelCase for parameters of CallAwsServiceCrossRegion #30795

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

tmokmss
Copy link
Contributor

@tmokmss tmokmss commented Jul 9, 2024

Issue # (if applicable)

closes #30799

Reason for this change

I found some AWS services uses camelCase for API parameters, such as api-gateway or bedrock-runtime. However, currently CallAwsServiceCrossRegion allows only PascalCase for parameters, and it throws an error if parameters are not in PascalCase.

Description of changes

Because we do not precisely know which service uses camelCase, this PR just removes the validation logic to allow both camelCase and PascalCase for parameters. This will also reduce maintanance cost in the future.

Description of how you validated changes

Added a unit test.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team July 9, 2024 11:01
@github-actions github-actions bot added star-contributor [Pilot] contributed between 25-49 PRs to the CDK p2 labels Jul 9, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@tmokmss
Copy link
Contributor Author

tmokmss commented Jul 9, 2024

Exemption Request: This PR only removes a synth-time validation so I think the unit test provides sufficient test coverage.

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Jul 9, 2024
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p1 and removed p2 labels Jul 10, 2024
@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Jul 10, 2024
@xazhao xazhao added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Jul 15, 2024
xazhao
xazhao previously approved these changes Jul 15, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review July 15, 2024 20:06

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 15, 2024
Copy link
Contributor

mergify bot commented Jul 15, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed xazhao’s stale review July 15, 2024 20:12

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 3ddc230
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 15, 2024
Copy link
Contributor

mergify bot commented Jul 15, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 5d6ace8 into aws:main Jul 15, 2024
14 checks passed
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 15, 2024
@tmokmss tmokmss deleted the fix-camelcase branch July 16, 2024 03:15
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p1 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stepfunctions-tasks: CallAwsServiceCrossRegion uses wrong casing for ECS
3 participants