Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(amplify-alpha): Add support for CodeStarSourceCodeProvider similar to CodePipeline's #30883

Open
2 tasks
syunta opened this issue Jul 18, 2024 · 1 comment
Open
2 tasks
Labels
@aws-cdk/aws-amplify Related to AWS Amplify effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p3

Comments

@syunta
Copy link

syunta commented Jul 18, 2024

Describe the feature

https://docs.aws.amazon.com/amplify/latest/userguide/setting-up-GitHub-access.html#setting-up-github-app-cloudformation

Existing Amplify apps that you previously connected from GitHub repositories use OAuth for repo access. This can include apps that you deployed using the Amplify Command Line Interface (CLI), AWS CloudFormation, or the SDKs. We strongly recommend that you migrate these apps to use the new Amplify GitHub App. Migration must be performed in the Amplify console in the AWS Management Console. For instructions, see Migrating an existing OAuth app to the Amplify GitHub App.

As stated above, there is no method to build Amplify using GitHub App. I hope for the support of CodeStarSourceCodeProvider similar to aws-cdk-lib/aws-codepipeline-actions.

https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_codepipeline_actions.CodeStarConnectionsSourceAction.html

Use Case

Migrating an existing OAuth app to the Amplify GitHub App.

Proposed Solution

    const amplifyApp = new amplify.App(this, 'Amplify', {
      appName: 'app',
      buildSpec: { ... },
      sourceCodeProvider: new amplify.CodeStarSourceCodeProvider({
        owner: 'owner',
        repository: 'repo',
        connectionArn: 'arn string'
      }),
    });

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

aws-cdk-lib: 2.142.1, @aws-cdk/aws-amplify-alpha: 2.149.0-alpha.0

Environment details (OS name and version, etc.)

macOS 14.2

@syunta syunta added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 18, 2024
@github-actions github-actions bot added the @aws-cdk/aws-amplify Related to AWS Amplify label Jul 18, 2024
@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Jul 18, 2024
@khushail khushail self-assigned this Jul 18, 2024
@khushail
Copy link
Contributor

Hi @syunta , Checking this doc, seems like CodeStarSourceCodeProvider is missing.
Thanks for requesting this feature. Submissions from the community are welcome in this regard.

@khushail khushail added p3 effort/small Small work item – less than a day of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Jul 18, 2024
@khushail khushail removed their assignment Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-amplify Related to AWS Amplify effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p3
Projects
None yet
Development

No branches or pull requests

2 participants