-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow all sts
options for roles assumed by the cli
#31089
Conversation
Signed-off-by: Sumu <sumughan@amazon.com>
…iling with tags in custom bootstrap Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
…s to cfnexecutionrole instead of deployrole Signed-off-by: Sumu <sumughan@amazon.com>
.../@aws-cdk-testing/cli-integ/resources/bootstrap-templates/custom-bootstrap-session-tags.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
* Instantiate an SDK for context providers. This function ensures that all | ||
* lookup assume role options are used when context providers perform lookups. | ||
*/ | ||
export async function initContextProviderSdk(aws: SdkProvider, options: cxschema.ContextLookupRoleOptions): Promise<ISDK> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rix0rrr Can you have a look at this (and how its being used)? I added it since your last review to fix the lookup issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is a copy of https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/cx-api/FEATURE_FLAGS.md and is actually configured to be ignored:
aws-cdk/packages/@aws-cdk/cx-api/.gitignore
Lines 3 to 9 in 1593500
* | |
!package.json | |
!.npmignore | |
!jest.config.js | |
!LICENSE | |
!NOTICE | |
!CONTRIBUTING.md |
But since it was committed before the ignore rules were put in place, it still lingers on.
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Allow passing all STS options to assume role configuration for various CDK roles.
Prerequisites
Issue # (if applicable)
Closes #26157
Fixes #22535
Reason for this change
Enabling ABAC via STS session tags. From the AWS docs:
Description of changes
The CDK creates 4 IAM roles during bootstrap. It then assumes these roles at various phases of the deployment.
Each of these roles should be assumable with their own specific session tags, as they server different purposes.
Session tags for each role will be configurable via synthesizer properties (similarly to how
externalId
is exposed) both for theDefaultStackSynthesizer
, and for a custom synthesizer extending theStackSynthesizer
class. The new properties will propagate down and will eventually be written to the cloud assembly.+ manifest.json
+ assets.json
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license