-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): hotswapping appsync functions fails when API does not return function on the first page #31406
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! The cli integ test you wrote is not succeeding. Did you run this locally to ensure it worked? If not, the instructions for how to do so are here.
Specifically the failure is this:
const api = new appsync.GraphqlApi(this, "Api", {
--
ReferenceError: appsync is not defined
Looks like you need to add a line like this to the top of app.js
. But please run the cli integ test on your own to ensure it does as its supposed to still!
Once that has been fixed i'll run it through the pipeline again.
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Pull request has been modified.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
aws-amplify/amplify-category-api#2307
Reason for this change
Hotswap for AppSync functions sometimes fails with
Deployment failed: MissingRequiredParameter: Missing required key 'functionId' in params
. This is because the SDK list function only retrieves the first page. In APIs where there are many functions it is possible for the hotswapped function to not be contained in the first page. This results in the previously mentioned error because thefunctionId
is never retrieved.Description of changes
List all AppSync functions for a given API by iterating through the pages with the
nextToken
. The change was modeled after a similar request here.Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license