fix(cli): sso with proxy fails #32261
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32261 +/- ##
=======================================
Coverage 77.17% 77.17%
=======================================
Files 105 105
Lines 7169 7169
Branches 1315 1315
=======================================
Hits 5533 5533
Misses 1455 1455
Partials 181 181
Flags with carried forward coverage won't be shown. Click here to find out more.
|
aws-cdk-automation
added
the
pr/needs-maintainer-review
iliapolo
changed the title
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
aws-cdk-automation
removed
the
pr/needs-maintainer-review
packages/aws-cdk/package.json
Outdated
| "@aws-sdk/credential-providers": "3.696.0", | ||
| "@aws-sdk/ec2-metadata-service": "3.696.0", | ||
| "@aws-sdk/lib-storage": "3.696.0", | ||
| "@aws-sdk/client-appsync": "^3.699.0", |
There was a problem hiding this comment.
Don't think it matters, but why the carets suddenly? I prefer to not include this change in this PR.
| "@aws-sdk/client-appsync": "^3.699.0", | |
| "@aws-sdk/client-appsync": "3.699.0", |
There was a problem hiding this comment.
Don't we need the carets to indicate to dependabot that it should keep it up to date? We used to have them for v2.
There was a problem hiding this comment.
We use npm-check-updates --minor (not dependabot) so it doesn't matter if there is a caret or not. No need for them.
iliapolo
added
pr-linter/exempt-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Comments on closed issues and PRs are hard for our team to see. |
Updating to the latest SDK version to pull in aws/aws-sdk-js-v3#6688
Followup to #32208
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license