-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cdk diff should indicate if only Output CF description added, then Cloudformation will not update. #778
Closed
ygoodmn opened this issue
Sep 26, 2018
· 1 comment
· Fixed by #2029 · May be fixed by MechanicalRock/account-reaper#6
Closed
cdk diff should indicate if only Output CF description added, then Cloudformation will not update. #778
ygoodmn opened this issue
Sep 26, 2018
· 1 comment
· Fixed by #2029 · May be fixed by MechanicalRock/account-reaper#6
Labels
feature-request
A feature should be added or improved.
package/tools
Related to AWS CDK Tools or CLI
Comments
srchase
added
feature-request
A feature should be added or improved.
and removed
enhancement
labels
Jan 3, 2019
I think that will occur exception when stack status is |
rix0rrr
added a commit
that referenced
this issue
Mar 16, 2019
If only stack Outputs are changed, CloudFormation generates a ChangeSet that is executable but has 0 changes. Before, we looked at the amount of changes to say there was nothing to do, but now we look at the actual change set status to determine whether it's an empty change set or not. The effect is that we can now deploy updates even if only Outputs changed. This becomes very important when the only thing changed to a stack is an Output got added because a cross-stack reference was taken by a downstream stack. Fixes #778.
rix0rrr
added a commit
that referenced
this issue
Mar 16, 2019
If only stack Outputs are changed, CloudFormation generates a ChangeSet that is executable but has 0 changes. Before, we looked at the amount of changes to say there was nothing to do, but now we look at the actual change set status to determine whether it's an empty change set or not. The effect is that we can now deploy updates even if only Outputs changed. This becomes very important when the only thing changed to a stack is an Output got added because a cross-stack reference was taken by a downstream stack. Fixes #778.
4 tasks
rix0rrr
added a commit
that referenced
this issue
Mar 18, 2019
If only stack Outputs are changed, CloudFormation generates a ChangeSet that is executable but has 0 changes. Before, we looked at the amount of changes to say there was nothing to do, but now we look at the actual change set status to determine whether it's an empty change set or not. The effect is that we can now deploy updates even if only Outputs changed. This becomes very important when the only thing changed to a stack is an Output got added because a cross-stack reference was taken by a downstream stack. Fixes #778.
rix0rrr
added a commit
to alex-berger/aws-cdk
that referenced
this issue
Mar 19, 2019
If only stack Outputs are changed, CloudFormation generates a ChangeSet that is executable but has 0 changes. Before, we looked at the amount of changes to say there was nothing to do, but now we look at the actual change set status to determine whether it's an empty change set or not. The effect is that we can now deploy updates even if only Outputs changed. This becomes very important when the only thing changed to a stack is an Output got added because a cross-stack reference was taken by a downstream stack. Fixes aws#778.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature-request
A feature should be added or improved.
package/tools
Related to AWS CDK Tools or CLI
CDK Version 0.9.0
Enhancement: cdk diff should indicate if only an Ouput Resource was Added, cloudformation will not update.
Steps:
Expected:
[+] Added (Output will be updated on next Resource update)
Actual:
+] Added
Example:
From Synth
Outputs:
LoadBalancerArn:
Description: NLB
Value:
Ref: NLB
Export:
Name: 'NLBArn'
From Terminal:
user@ubuntu:~/sms100$ cdk deploy cdk-NLB
Starting deployment of stack cdk-NLB...
Stack was already up-to-date, it has ARN arn:aws:cloudformation:us-west-1:123456:stack/cdk-NLB/01314e0-c15f-11e8-ab9b-50fae8123456 cdk-sms104-NLB
user@ubuntu:~/sms100$ cdk diff cdk-NLB
[+] Added LoadBalancerArn: {"Description":"NLB","Value":{"Ref":"NLB"},"Export":{"Name":{"NLBArn"}}}''
The text was updated successfully, but these errors were encountered: