[cli] spawn error when node path includes space on Windows

[atrick-speedline]

Windows users commonly install node in the "Program Files" directory. Using WSL, this works fine (even if the path to node has a space), but using Git Bash or cmd.exe, you get the an error when running cdk synth (see below).

Reproduction Steps

Make a basic cdk app, make sure node is in "Program Files", run cdk synth --app path/to/app.js.

Error Log

'C:\Program' is not recognized as an internal or external command,
operable program or batch file.
Subprocess exited with error 1

Environment

• CLI Version : Git Bash
• Framework Version: 1.54.0
• Node.js Version: v12.18.0
• OS : Windows 10
• Language (Version): TypeScript (3.9.6)

Other

Removing the shell argument in the call to childProcess.spawn in aws-cdk/lib/api/cxapp/exec.ts fixes the issue.

---

This is 🐛 Bug Report

[atrick-speedline]

By the way, I'm not entirely sure this is a bug with aws-cdk. After reading the documentation for child_process.spawn, it's entirely unclear to me how, or if, the shell argument is supposed to effect escaping.

[shivlaks]

@atrick-speedline I'm also not sure if this is a bug yet

Since there is a workaround, I think we should mark it as a p2 for now and investigate further.
Thanks for creating this issue and for the workaround, it might help someone else who runs into the same friction.

[github-actions]

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.